<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ok, sounds good to me.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 12:06 PM, Anna Zaks <<a href="mailto:ganna@apple.com" class="">ganna@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 11:48 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com" class="">kremenek@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">This looks fine to me, although the list might want a bit more motivation. The idea here is to compose this with "--analyze" so that users can selectively opt out specific files from static analysis.</div></div></div></blockquote>Will add to commit message.<br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">There looks like some unintended changes in the patch:</div><div class=""><br class=""></div><div class=""><div class="">- getInliningModeForFunction(const Decl *D, const SetOfConstDecls &Visited);</div><div class="">+ getInliningModeForFunction(const Decl *D, const SetOfConstDecls &Visited);</div><div class=""> </div></div><div class="">Looks like an unintended indentation change unrelated to this patch.</div><div class=""><br class=""></div></div></div></blockquote><div class=""><br class=""></div><div class="">The indentation was wrong in the file I was editing, so I've decided to correct. It's unrelated code, but the same file..</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Also:</div><div class=""><br class=""></div><div class=""><div class="">+ // Don't analyze if the user explicitely asked for no checks to be performed</div><div class="">+ // on this file.</div></div><div class=""><br class=""></div><div class="">explicitely -> explicitly</div><div class=""><br class=""></div></div></div></blockquote><br class="">Thanks.</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Can you also add to the test case showing that the option works when the -analyzer-checker and -analyzer-disable-all-checkers are inverted?</div><div class=""><br class=""></div><div class="">For example, take this RUN line:</div><div class=""><br class=""></div><div class="">+// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-store=region -analyzer-disable-all-checks -verify %s</div><div class=""><br class=""></div><div class="">and also add:</div><div class=""><br class=""></div><div class="">+// RUN: %clang_cc1 -analyze -analyzer-disable-all-checks -analyzer-checker=core -analyzer-store=region -verify %s</div><div class=""> </div><div class="">just to show the two behave the same.</div></div></div></blockquote><div class=""><br class=""></div>Will do.</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 11:38 AM, Anna Zaks <<a href="mailto:ganna@apple.com" class="">ganna@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="margin: 0px;" class=""><div style="margin: 0px;" class="">Please, review:</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">Add an option to silence all analyzer warnings.</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">People have been incorrectly using "-analyzer-disable-checker" to </div><div style="margin: 0px;" class="">silence analyzer warnings on a file, when analyzing a project. Add </div><div style="margin: 0px;" class="">the "-analyzer-disable-all-checks" option, which would allow to do </div><div style="margin: 0px;" class="">this and suggest it as part of the error message for </div><div style="margin: 0px;" class="">"-analyzer-disable-checker".</div><div style="margin: 0px;" class=""><font face="Menlo" size="3" class=""><br class=""></font></div><div style="margin: 0px;" class=""></div></div></div><span id="cid:2A2DC90E-ED79-49B1-89F2-2ECC4B81BC1F@apple.com" class=""><disable-all-checks.diff></span><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="margin: 0px;" class=""><div style="margin: 0px;" class=""></div></div></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@cs.uiuc.edu" class="">cfe-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>