<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Code looks good. I would suggest adding to the comment above the AnalyzerOptions setting to explain why we still want to do any processing at all (i.e. to validate the command-line options and ensure the file still parses, as you pointed out to me yesterday).</div><div class=""><br class=""></div><div class="">Nitpick: the option should be next to other bitfield options; otherwise it will take up a whole word on its own.</div><div class=""><br class=""></div><div class="">Jordan</div><div class=""> </div><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 11:38, Anna Zaks <<a href="mailto:ganna@apple.com" class="">ganna@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="margin: 0px;" class=""><div style="margin: 0px;" class="">Please, review:</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">Add an option to silence all analyzer warnings.</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">People have been incorrectly using "-analyzer-disable-checker" to </div><div style="margin: 0px;" class="">silence analyzer warnings on a file, when analyzing a project. Add </div><div style="margin: 0px;" class="">the "-analyzer-disable-all-checks" option, which would allow to do </div><div style="margin: 0px;" class="">this and suggest it as part of the error message for </div><div style="margin: 0px;" class="">"-analyzer-disable-checker".</div><div style="margin: 0px;" class=""><font face="Menlo" size="3" class=""><br class=""></font></div><div style="margin: 0px;" class=""></div></div></div><span id="cid:92DA5739-CF10-4E31-9079-B7020B7880B3@apple.com"><disable-all-checks.diff></span><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="margin: 0px;" class=""><div style="margin: 0px;" class=""></div></div></div></div></blockquote></div><br class=""></body></html>