<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 1:26 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com" class="">jordan_rose@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class=""><br class="Apple-interchange-newline">On Aug 29, 2014, at 12:06 , Anna Zaks <<a href="mailto:ganna@apple.com" class="">ganna@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite" class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 29, 2014, at 11:48 AM, Ted Kremenek <<a href="mailto:kremenek@apple.com" class="">kremenek@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class="">This looks fine to me, although the list might want a bit more motivation. The idea here is to compose this with "--analyze" so that users can selectively opt out specific files from static analysis.</div></div></div></blockquote>Will add to commit message.<br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class=""><br class=""></div><div class="">There looks like some unintended changes in the patch:</div><div class=""><br class=""></div><div class=""><div class="">- getInliningModeForFunction(const Decl *D, const SetOfConstDecls &Visited);</div><div class="">+ getInliningModeForFunction(const Decl *D, const SetOfConstDecls &Visited);</div><div class=""> </div></div><div class="">Looks like an unintended indentation change unrelated to this patch.</div><div class=""><br class=""></div></div></div></blockquote><div class=""><br class=""></div><div class="">The indentation was wrong in the file I was editing, so I've decided to correct. It's unrelated code, but the same file..</div><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class="">Also:</div><div class=""><br class=""></div><div class=""><div class="">+ // Don't analyze if the user explicitely asked for no checks to be performed</div><div class="">+ // on this file.</div></div><div class=""><br class=""></div><div class="">explicitely -> explicitly</div><div class=""><br class=""></div></div></div></blockquote><br class="">Thanks.</div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class="">Can you also add to the test case showing that the option works when the -analyzer-checker and -analyzer-disable-all-checkers are inverted?</div><div class=""><br class=""></div><div class="">For example, take this RUN line:</div><div class=""><br class=""></div><div class="">+// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-store=region -analyzer-disable-all-checks -verify %s</div><div class=""><br class=""></div><div class="">and also add:</div><div class=""><br class=""></div><div class="">+// RUN: %clang_cc1 -analyze -analyzer-disable-all-checks -analyzer-checker=core -analyzer-store=region -verify %s</div><div class=""> </div><div class="">just to show the two behave the same.</div></div></div></blockquote><div class=""><br class=""></div>Will do.</div></div></blockquote><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Oooops, Ted's comments reminded me of one more test: %clang --analyze %s -Xanalyzer -analyzer-disable-all-checks. Just to test everything through the driver, which is what we really care about.</div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div></div></blockquote><div><br class=""></div>Done in r216783.</div><div>Thanks,</div><div>Anna.<br class=""><blockquote type="cite" class=""><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Jordan</div></div></blockquote></div><br class=""></body></html>