<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 26, 2014 at 11:29 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Wed Aug 27 01:29:07 2014<br>
New Revision: 216529<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216529&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216529&view=rev</a><br>
Log:<br>
Simplify creation of a couple ArrayRefs by using None and makeArrayRef.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-query/Query.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-query/Query.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-query/Query.cpp?rev=216529&r1=216528&r2=216529&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-query/Query.cpp?rev=216529&r1=216528&r2=216529&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/clang-query/Query.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-query/Query.cpp Wed Aug 27 01:29:07 2014<br>
@@ -92,8 +92,8 @@ bool MatchQuery::run(llvm::raw_ostream &<br>
             TD.emitDiagnostic(<br>
                 R.getBegin(), DiagnosticsEngine::Note,<br>
                 "\"" + BI->first + "\" binds here",<br>
-                ArrayRef<CharSourceRange>(CharSourceRange::getTokenRange(R)),<br>
-                ArrayRef<FixItHint>(), &AST->getSourceManager());<br>
+                llvm::makeArrayRef(CharSourceRange::getTokenRange(R)),<br></blockquote><div><br></div><div>Could you drop the makeArrayRef entirely here & just rely on ArrayRef's one-arg implicit conversion?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+                None, &AST->getSourceManager());<br>
           }<br>
           break;<br>
         }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>