<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 26, 2014, at 2:07 PM, Jordan Rose <<a href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 26, 2014, at 13:15 , Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 26, 2014 at 11:13 AM, Fariborz Jahanian<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: fjahanian<br>Date: Tue Aug 26 13:13:47 2014<br>New Revision: 216469<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=216469&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216469&view=rev</a><br>Log:<br>c11- Check for c11 language option as documentation says<br>feature is c11 about nested struct declarations must have<br>struct-declarator-list. Without this change, code<br>which was meant for c99 breaks.<span class="Apple-converted-space"> </span><a href="rdar://18125536">rdar://18125536</a><br></blockquote><div><br></div><div>This change does not look correct; the same rule existed in C89 and C99 too (but it was enforced by the grammar in those languages). [Additionally, your commit message is a bit garbled, you didn't add a new test case, and the only other information you provide is a link to an Apple-internal bug, so I'm not even sure what problem you're trying to fix.]</div><div> </div></div></div></div></div></blockquote><br></div><div>Shoot, I'm sorry. Richard is right—this rule does fall out of the grammar, so the original code is (technically) illegal in C99.</div></div></blockquote><div><br></div>Thanks Jordan for clarifying. I then revert the patch and ask project owners to add the warning-compression flag (or modify their code).</div><div>- Fariborz</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div><br></div><div>Jordan</div></div></blockquote></div><br></body></html>