<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Renato,<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 25, 2014, at 5:23 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org" class="">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">On 22 August 2014 01:27, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:<br class=""><blockquote type="cite" class="">Author: qcolombet<br class="">Date: Thu Aug 21 19:27:52 2014<br class="">New Revision: 216249<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216249&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=216249&view=rev</a><br class="">Log:<br class="">[test/CodeGen/ARM] Adpat test to match new codegen after r216236.<br class=""></blockquote><br class=""><br class="">Hi Quentin,<br class=""><br class="">I think removing the tests is not a good idea, since they're not<br class="">testing optimizations, but the correct lowering of the intrinsics.<br class=""><br class="">The right way of fixing this test is to avoid the optimization to<br class="">occur, by making the parameters extern variables or the like.<br class=""></div></blockquote><div><br class=""></div><div>The problem is that the intrinsics at stake are just fancy moves, that can be coalesced. I do not think there is a way to prevent the optimization to happen other than disabling the optimization.</div><div>I can add the flag to do that, but I guess that wouldn’t be the right fix, since we could have another backend that LLVM.</div><div>If we do want to check the lowering of intrinsics, shouldn’t we drop Os from the run command?</div><div><br class=""></div><div>To get a sense of what is different, here are a few examples,</div><div><div style="margin: 0px;" class=""><div style="margin: 0px;" class="">_test_vdup_n_u32:</div><div style="margin: 0px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>vmov<span class="Apple-tab-span" style="white-space:pre"> </span>d16, r0, r0</div><div style="margin: 0px;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>vmov<span class="Apple-tab-span" style="white-space:pre"> </span>r0, r1, d16</div><div style="margin: 0px;" class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>bx<span class="Apple-tab-span" style="white-space: pre;"> </span>lr</div><div style="margin: 0px;" class=""><font face="Menlo" class=""><span style="font-size: 11px;" class="">=></span></font></div></div></div></div><div><div>_test_vdup_n_u32:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>mov<span class="Apple-tab-span" style="white-space:pre"> </span>r1, r0</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>bx<span class="Apple-tab-span" style="white-space:pre"> </span>lr</div><div><br class=""></div><div>———</div><div><div>_test_vcreate_s64:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>vmov.32<span class="Apple-tab-span" style="white-space:pre"> </span>d16[0], r0</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>vmov.32<span class="Apple-tab-span" style="white-space:pre"> </span>d16[1], r1</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>vmov<span class="Apple-tab-span" style="white-space:pre"> </span>r0, r1, d16</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>bx<span class="Apple-tab-span" style="white-space:pre"> </span>lr</div><div>=></div><div><div>_test_vcreate_s64:</div><div><span class="Apple-tab-span" style="white-space: pre;"> </span>bx<span class="Apple-tab-span" style="white-space: pre;"> </span>lr</div><div><br class=""></div><div>———</div><div><div>_test_vget_lane_u32:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>vmov<span class="Apple-tab-span" style="white-space:pre"> </span>d0, r0, r1</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>vmov<span class="Apple-tab-span" style="white-space:pre"> </span>r0, s1</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>bx<span class="Apple-tab-span" style="white-space:pre"> </span>lr</div><div>=></div><div><div>_test_vget_lane_u32:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>mov<span class="Apple-tab-span" style="white-space:pre"> </span>r0, r1</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>bx<span class="Apple-tab-span" style="white-space:pre"> </span>lr</div><div><br class=""></div><div>Thanks,</div><div>-Quentin</div></div></div></div></div><blockquote type="cite" class=""><div class=""><br class="">cheers,<br class="">--renato<br class=""></div></blockquote></div><br class=""></div></body></html>