Huh, I thought I had fixed them - do you happen to know what is special about this build-bot? Or did I just misinterpret the other buildbots and need to learn how to read them better?<br><div><br></div><div>Thanks!</div><br>
<div class="gmail_quote">On Mon Aug 18 2014 at 1:16:05 AM Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com">ghoflehner@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ghoflehner<br>
Date: Mon Aug 18 18:03:30 2014<br>
New Revision: 215947<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=215947&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=215947&view=rev</a><br>
Log:<br>
[clang-rename] revert r215839<br>
<br>
The commit broke public build bots for more than 24 hours.<br>
<br>
(view as text)<br>
******************** TEST 'Clang Tools :: clang-rename/VarTest.cpp' FAILED ********************<br>
Script:<br>
--<br>
cat /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang.src/tools/extra/test/<u></u>clang-rename/VarTest.cpp > /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang-build/tools/clang/tools/<u></u>extra/test/clang-rename/<u></u>Output/VarTest.cpp.tmp.cpp<br>
clang-rename -offset=$(grep -FUbo 'foo;' /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang-build/tools/clang/tools/<u></u>extra/test/clang-rename/<u></u>Output/VarTest.cpp.tmp.cpp | head -1 | cut -d: -f1) -new-name=hector /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang-build/tools/clang/tools/<u></u>extra/test/clang-rename/<u></u>Output/VarTest.cpp.tmp.cpp -i --<br>
sed 's,//.*,,' /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang-build/tools/clang/tools/<u></u>extra/test/clang-rename/<u></u>Output/VarTest.cpp.tmp.cpp | FileCheck /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang.src/tools/extra/test/<u></u>clang-rename/VarTest.cpp<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
clang-rename: could not find symbol at /Users/buildslave/zorg/<u></u>buildbot/smooshlab/slave-0.8/<u></u>build.clang-x86_64-darwin11-<u></u>nobootstrap-RAincremental/<u></u>clang-build/tools/clang/tools/<u></u>extra/test/clang-rename/<u></u>Output/VarTest.cpp.tmp.cpp:2:1 (offset 14).<br>
<br>
<br>
Removed:<br>
clang-tools-extra/trunk/clang-<u></u>rename/<br>
clang-tools-extra/trunk/test/<u></u>clang-rename/<br>
clang-tools-extra/trunk/<u></u>unittests/clang-rename/<br>
Modified:<br>
clang-tools-extra/trunk/<u></u>CMakeLists.txt<br>
clang-tools-extra/trunk/<u></u>Makefile<br>
clang-tools-extra/trunk/test/<u></u>CMakeLists.txt<br>
clang-tools-extra/trunk/<u></u>unittests/CMakeLists.txt<br>
<br>
Modified: clang-tools-extra/trunk/<u></u>CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/clang-tools-extra/<u></u>trunk/CMakeLists.txt?rev=<u></u>215947&r1=215946&r2=215947&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- clang-tools-extra/trunk/<u></u>CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/<u></u>CMakeLists.txt Mon Aug 18 18:03:30 2014<br>
@@ -1,6 +1,5 @@<br>
add_subdirectory(clang-apply-<u></u>replacements)<br>
add_subdirectory(clang-<u></u>modernize)<br>
-add_subdirectory(clang-<u></u>rename)<br>
add_subdirectory(modularize)<br>
add_subdirectory(module-map-<u></u>checker)<br>
add_subdirectory(remove-cstr-<u></u>calls)<br>
<br>
Modified: clang-tools-extra/trunk/<u></u>Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/Makefile?rev=215947&r1=215946&r2=215947&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/clang-tools-extra/<u></u>trunk/Makefile?rev=215947&r1=<u></u>215946&r2=215947&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- clang-tools-extra/trunk/<u></u>Makefile (original)<br>
+++ clang-tools-extra/trunk/<u></u>Makefile Mon Aug 18 18:03:30 2014<br>
@@ -13,8 +13,8 @@ include $(CLANG_LEVEL)/../../Makefile.<u></u>co<br>
<br>
PARALLEL_DIRS := remove-cstr-calls tool-template modularize \<br>
module-map-checker pp-trace<br>
-DIRS := clang-apply-replacements clang-modernize clang-rename clang-tidy \<br>
- clang-query unittests<br>
+DIRS := clang-apply-replacements clang-modernize clang-tidy clang-query \<br>
+ unittests<br>
<br>
include $(CLANG_LEVEL)/Makefile<br>
<br>
<br>
Modified: clang-tools-extra/trunk/test/<u></u>CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/clang-tools-extra/<u></u>trunk/test/CMakeLists.txt?rev=<u></u>215947&r1=215946&r2=215947&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- clang-tools-extra/trunk/test/<u></u>CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/test/<u></u>CMakeLists.txt Mon Aug 18 18:03:30 2014<br>
@@ -37,7 +37,6 @@ set(CLANG_TOOLS_TEST_DEPS<br>
# Individual tools we test.<br>
clang-apply-replacements<br>
clang-modernize<br>
- clang-rename<br>
clang-query<br>
clang-tidy<br>
modularize<br>
<br>
Modified: clang-tools-extra/trunk/<u></u>unittests/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/CMakeLists.txt?rev=215947&r1=215946&r2=215947&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/clang-tools-extra/<u></u>trunk/unittests/CMakeLists.<u></u>txt?rev=215947&r1=215946&r2=<u></u>215947&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- clang-tools-extra/trunk/<u></u>unittests/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/<u></u>unittests/CMakeLists.txt Mon Aug 18 18:03:30 2014<br>
@@ -7,6 +7,5 @@ endfunction()<br>
<br>
add_subdirectory(clang-apply-<u></u>replacements)<br>
add_subdirectory(clang-<u></u>modernize)<br>
-add_subdirectory(clang-<u></u>rename)<br>
add_subdirectory(clang-query)<br>
add_subdirectory(clang-tidy)<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</blockquote></div>