<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Fair enough, committed in r215453. Thanks, Grant!</div><div><br></div><div>Jordan</div><div><br></div><br><div><div>On Aug 9, 2014, at 17:53 , Grant Paul <<a href="mailto:grant@grantpaul.com">grant@grantpaul.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I agree completely with discouraging @synchronized, and tend to avoid it myself. The reasoning behind this patch is a discussion I was having with someone who works on code which does use @synchronized extensively, and they complained about Clang not supporting implicit conversions when using C++ wrapper objects. I don't have a strong reason to request this patch be merged, but it would be nice to be able to say that issue is fixed.<div>
<br></div><div>Thanks,<br><div><br></div><div>Grant</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 5, 2014 at 6:21 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I feel obliged to advise you to switch away to @synchronized to something more efficient and more appropriate for your use case. I'm not sure it's worth improving @synchronized when it's really not a good default choice for concurrency protection.<br>
<br>
Jordan<br>
<div><div class="h5"><br>
<br>
On Aug 2, 2014, at 18:17 , Grant Paul <<a href="mailto:grant@grantpaul.com">grant@grantpaul.com</a>> wrote:<br>
<br>
> Hi,<br>
><br>
> Attached is a patch to allow implicitly converting C++ wrapper objects in @synchronized. Many projects (Chromium, MobileCydia, etc) use RAII-based handles for Objective-C objects, but are not able to use those handles in @synchronized without an explicit cast.<br>
><br>
> Thanks,<br>
><br>
> Grant<br>
</div></div>> <synchronized.patch>_______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>