<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Aaron,<div><br></div><div>Thanks for investigating this!</div><div><br></div><div>I was looking at the code again and I thought maybe the crash is due to this code in HandlePragmaLoopHint</div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> IdentifierInfo *OptionInfo = Info->Option.getIdentifierInfo();</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Hint.OptionLoc = IdentifierLoc::create(</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Actions.Context, Info->Option.getLocation(), OptionInfo);</div></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"><br></div><div style="margin: 0px;">The call to 'Info->Option.getIdentifierInfo();’ might be failing because with nounroll and sometimes unroll an option is not specified. I assumed it would just return null. But that could be a poor assumption. If that is the case then it should be moved below the test that returns early if #pragma unroll or #pragma nounroll are specified.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"><br></div><div style="margin: 0px;"><div style="font-size: 11px; font-family: Menlo; margin: 0px;"> if (TokSize == 0 && (PragmaUnroll || PragmaNoUnroll)) {</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"> ConsumeToken(); // The annotation token.</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"> Hint.Range = Info->PragmaName.getLocation();</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"> return true;</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"> }</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"><br></div><div style="margin: 0px;">The windows build-bots seem rather busy. Could you give this a try?</div><div style="margin: 0px;"><br></div><div style="margin: 0px;">Thanks,</div><div style="margin: 0px;"><br></div><div style="margin: 0px;">Tyler</div><div style="font-size: 11px; font-family: Menlo; margin: 0px;"><br></div></div><div><div><div>On Jul 31, 2014, at 2:07 PM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Thu, Jul 31, 2014 at 4:25 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><blockquote type="cite">Thanks,<br><br>I don’t have valgrind or a windows machine. Let me know if the resubmit works for you.<br></blockquote><br>It's still crashing for me on Windows. I will investigate.<br><br>~Aaron<br></blockquote></div><br></div></body></html>