<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Committed in r<span style="font-family: Menlo; font-size: 11px;">214333.</span></div><div><br></div><div><div>On Jul 30, 2014, at 11:52 AM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Wed, Jul 30, 2014 at 1:33 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><blockquote type="cite">Hi Aaron,<br><br>Thanks for the review! Here is the updated patch and responses to some of<br>your comments. The new tests are a couple of lines added to<br>test/Parser/pragma-loop.cpp. This patch is just refactoring in preparation<br>for new features so there really isn’t a need for new tests.<br></blockquote><br>I only mentioned the tests because your original email had said "A<br>couple of new tests are included as well." But the latest patch has<br>your updated test, so I'm all set there.<br></div></blockquote><div><br></div>Oops, sorry must have missed them in the first patch.</div><div><br></div><div><br><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Your changes LGTM! If you want to change the comment discussed above,<br>that's cool, but it's certainly not holding back the patch.<br><br>~Aaron</div></blockquote></div><br></body></html>