<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div><br></div><br><div><div>On Jul 28, 2014, at 3:00 PM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Mon, Jul 28, 2014 at 5:37 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><blockquote type="cite"><br><blockquote type="cite"><blockquote type="cite">Hi,<br><br>My internship finishes up this week, and Aaron informed me he won’t be able<br>to respond until next week. Would someone be able to review the patches<br>these patches so I can get them in before I leave?<br></blockquote><br>Not to make a liar of you (I really am on "vacation"), but I don't<br>want you to get stuck waiting on me. :-)<br><br>Minor comments, but with fixing them up, LGTM!<br></blockquote><br>Thanks! Sorry to drag you away from your vacation.<br></blockquote><br>No worries. :-)<br><br><blockquote type="cite"><br>I made your corrections and I will commit the patch. The only think I didn’t do was to change the raw_ostream because this patch is a lead-up to the constant expression patch. AFAIK the only way to print a constant expression is to use printPretty which requires a raw_ostream. So 'OS << value' in the this patch becomes 'value->printPretty(OS, nullptr, Policy);’ in the next.<br></blockquote><br>Ah, sounds good to me!<br><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Index: include/clang/Basic/Attr.td<br>===================================================================<br>--- include/clang/Basic/Attr.td (revision 214099)<br>+++ include/clang/Basic/Attr.td (working copy)<br>@@ -1815,12 +1815,6 @@<br> llvm_unreachable("Unhandled LoopHint option.");<br> }<br><br>- static StringRef getValueName(int Value) {<br>- if (Value)<br>- return "enable";<br>- return "disable";<br>- }<br>-<br></blockquote><br>Good catch here, but will this conflict with Mark's upcoming patch? I<br>don't think it will, but better to ask now. ;-)<br></blockquote><br>I don’t think so. Mark’s nounroll patch is already in.<br></blockquote><br>Phew. :-)<br><br>~Aaron</div></blockquote></div><br></body></html>