<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi,</div><div><br></div><div>My internship finishes up this week, and Aaron informed me he won’t be able to respond until next week. Would someone be able to review the patches these patches so I can get them in before I leave?</div><div><br></div><div>Perhaps Richard?</div><div><br></div><div>Thanks,</div><div><br></div><div>Tyler</div><br><div><div>On Jul 28, 2014, at 10:51 AM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi,<div><br></div><div>Please review the following patch. I split out the changes to the attribute that modify how printing is done in preparation for the constant expression changes. This should reduce the size of the constant expression patch a bit.</div><div><br></div><div>Tyler</div><div><br></div><div></div></div>
<span><pragma_print-svn.patch></span><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div><br></div><div><br><div><div>On Jul 25, 2014, at 2:06 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jul 25, 2014, at 8:13 AM, Aaron Ballman <<a href="mailto:aaron.ballman@gmail.com">aaron.ballman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Thu, Jul 24, 2014 at 6:48 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><blockquote type="cite">Hi Aaron,<br><br>Thanks for the review!<br><br>There were a number of conflicts with the work on pragma unroll and nounroll. To accommodate these directives I changed the Enabled argument of the loop hint attribute to a state argument. The state argument can be default, enable, or disable. Attributes like ‘#pragma unroll’ that don’t have any arguments use the default state.<br></blockquote><br>I would prefer this to be a separate change if at all possible (as a<br>predecessor to this patch) as it seems to be fairly substantive --<br>there's about a 17kb difference between this patch and the last one.<br>;-)<br></div></blockquote><br></div><div>The change I was describing was between the previous version of my patch and the current. Right now in trunk there is no ‘Enabled’ argument. Currently an integer is used to keep track of both the state and value. Ideally we should have a union of both the state and constant expression. That will require a little tablegen magic.</div><div><br></div><div>I agree the patch is a bit bigger. If you think it is required I can try to split it up a bit.</div><div><br></div><div>Tyler</div></div>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></blockquote></div><br></div></div>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>