<div dir="ltr">Yup, this is needed because the TypoExpr generally isn't transformed until well after the function which provided an appropriate callback would have gone out of scope, and the TypoCorrectionConsumer isn't called upon to provide correction candidates that pass any validation the callback performs until the TypoExpr is transformed.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 25, 2014 at 1:58 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks fine as a mechanical change; if the final approach to ownership needs this, then LGTM.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">2014-07-14 16:55 GMT-07:00 Kaelyn Takata <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">---<br>
 include/clang/Parse/Parser.h      |  5 ++--<br>
 include/clang/Sema/Sema.h         | 27 +++++++++----------<br>
 include/clang/Sema/SemaInternal.h | 18 ++++++-------<br>
 lib/Parse/ParseExpr.cpp           |  8 +++---<br>
 lib/Parse/ParseStmt.cpp           |  6 ++---<br>
 lib/Parse/ParseTentative.cpp      |  8 +++---<br>
 lib/Parse/Parser.cpp              |  8 +++---<br>
 lib/Sema/SemaCXXScopeSpec.cpp     |  9 +++----<br>
 lib/Sema/SemaDecl.cpp             | 57 +++++++++++++++++++--------------------<br>
 lib/Sema/SemaDeclCXX.cpp          | 27 ++++++++++---------<br>
 lib/Sema/SemaDeclObjC.cpp         | 21 +++++++--------<br>
 lib/Sema/SemaExpr.cpp             | 37 ++++++++++++-------------<br>
 lib/Sema/SemaExprMember.cpp       | 15 +++++------<br>
 lib/Sema/SemaExprObjC.cpp         | 18 ++++++-------<br>
 lib/Sema/SemaInit.cpp             |  4 +--<br>
 lib/Sema/SemaLambda.cpp           |  4 +--<br>
 lib/Sema/SemaLookup.cpp           | 27 +++++++++++--------<br>
 lib/Sema/SemaOpenMP.cpp           |  7 +++--<br>
 lib/Sema/SemaOverload.cpp         | 23 +++++++++-------<br>
 lib/Sema/SemaTemplate.cpp         | 17 ++++++------<br>
 lib/Sema/SemaTemplateVariadic.cpp |  8 +++---<br>
 21 files changed, 179 insertions(+), 175 deletions(-)<br>
<br>
<br></div></div>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>