<div dir="ltr">Does `set -e` at the top do the job as well? Then you wouldn't need the two `|| exit $?`s. (I think sed doesn't set an error code if it can't find matches.)</div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Wed, Jul 23, 2014 at 4:49 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: d0k<br>
Date: Wed Jul 23 06:49:49 2014<br>
New Revision: 213739<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=213739&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=213739&view=rev</a><br>
Log:<br>
check_clang_tidy_fix.sh: Fail immediately if clang-tidy crashes.<br>
<br>
Otherwise we'll get confusing messages from FileCheck instead of seeing the real issue.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=213739&r1=213738&r2=213739&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=213739&r1=213738&r2=213739&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh Wed Jul 23 06:49:49 2014<br>
@@ -12,7 +12,7 @@ TEMPORARY_FILE=$3.cpp<br>
 sed 's#// *[A-Z-]\+:.*#//#' ${INPUT_FILE} > ${TEMPORARY_FILE}<br>
<br>
 clang-tidy ${TEMPORARY_FILE} -fix --checks="-*,${CHECK_TO_RUN}" -- --std=c++11 \<br>
-  > ${TEMPORARY_FILE}.msg 2>&1<br>
+  > ${TEMPORARY_FILE}.msg 2>&1 || exit $?<br>
<br>
 FileCheck -input-file=${TEMPORARY_FILE} ${INPUT_FILE} \<br>
   -check-prefix=CHECK-FIXES -strict-whitespace || exit $?<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>