<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 15, 2014 at 3:07 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 16/07/2014 00:38, Nico Weber wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
On Tue, Jul 15, 2014 at 10:08 AM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
<br>
On 15/07/2014 05:07, Nico Weber wrote:<br>
<br>
On Mon, Jul 14, 2014 at 4:15 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a><br></div>
<mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a><div><div class="h5"><br>
<mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>>> wrote:<br>
<br>
Author: alp<br>
Date: Mon Jul 14 18:15:48 2014<br>
New Revision: 213010<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=213010&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=213010&view=rev</a><br>
Log:<br>
Define ENABLE_CLANG_ARCMT in the legacy build system too<br>
<br>
<br>
As far as I know, make is just as supported as cmake, no?<br>
<br>
<br>
Not really. it hasn't seen any of the feature work CMake has for<br>
at least a year. You only need to look at SVN logs to see all the<br>
hard work and hours spent on the CMake setup to make it outclass<br>
the other setup.<br>
<br>
<br>
Or to see that the CMake build is maintenance for some reason ;-)<br>
<br>
<br>
Platform support is limited compared to CMake, likewise<br>
cross-compilation has been left behind thanks to the remarkable<br>
CMake sub-invocation work. No compilation database generation,<br>
meaning a poor experience for anyone trying to use tooling on the<br>
codebase. Broken dependency scanning, you have to "touch" files or<br>
risk getting miscompiles. And there are many Windows developers<br>
contributing these days -- their enhancements basically only ever<br>
get added to CMake while Makefiles are left with minimal build fixes.<br>
<br>
Then there's bit rot. Various clang tests aren't supported with<br>
the 'makefiles' build -- they're simply not run -- the set of<br>
installed headers isn't necessarily canonical with makefiles<br>
either. Whenever I've pinged that makefiles need to track some<br>
change or other, nobody's been too interested in following up. So<br>
users really aren't getting the "full LLVM experience" with it at<br>
this point, the 'makefiles' bots aren't getting full coverage etc.<br>
<br>
As far as I can tell it would take a large effort to get the<br>
traditional build system on par with CMake at this point and<br>
nobody's puting in the time to actually do that. While supported,<br>
the old system definitely meets the definition of "legacy". Only<br>
commits could have changed that, not any amount of hand waving or<br>
arguing that it's still the default in "buildit" :-)<br>
<br>
<br>
Sounds like you prefer the cmake build,<br>
</div></div></blockquote>
<br>
No, I mean it really isn't that well supported.</blockquote><div><br></div><div>There's a buildbot that uses it, and people fix it if it breaks. (See e.g. this change.)</div><div><br></div><div>(Note that I'm not particularly attached to the make build – if the llvm project decides to drop make and only keep cmake around, I wouldn't argue against that. But that hasn't happened yet.)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
but there wasn't some thread about this that I missed. So please just say "in make" instead of "legacy build system" (it's more concise, too!)<br>
</blockquote>
<br></div>
"in make"? That's a new one :-)<br></blockquote><div><br></div><div>Maybe "with make"? "for make"? I don't speak English, but there's probably some verbal construct to express the sentiment I'm going for :-)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
<br>
<br>
<br>
<br>
<br>
<br>
Modified:<br>
cfe/trunk/tools/libclang/<u></u>Makefile<br>
<br>
Modified: cfe/trunk/tools/libclang/<u></u>Makefile<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Makefile?rev=213010&r1=213009&r2=213010&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/tools/<u></u>libclang/Makefile?rev=213010&<u></u>r1=213009&r2=213010&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/tools/libclang/<u></u>Makefile (original)<br>
+++ cfe/trunk/tools/libclang/<u></u>Makefile Mon Jul 14 18:15:48 2014<br>
@@ -37,6 +37,10 @@ ifeq ($(HOST_OS), $(filter $(HOST_OS), L<br>
LLVMLibsOptions +=<br>
-Wl,-soname,lib$(LIBRARYNAME)$<u></u>(SHLIBEXT)<br>
endif<br>
<br>
+ifeq ($(ENABLE_CLANG_ARCMT),1)<br>
+ CXX.Flags += -DCLANG_ENABLE_ARCMT<br>
+endif<br>
+<br>
##===-------------------------<u></u>------------------------------<u></u>---------------===##<br>
# FIXME: This is copied from the 'lto' makefile. Should<br>
we share<br>
this?<br>
##===-------------------------<u></u>------------------------------<u></u>---------------===##<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br></div>
<mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>>><div class="">
<br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br>
<br>
-- <a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
<br>
</div></blockquote><div class="HOEnZb"><div class="h5">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div></div>