<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 15, 2014 at 10:08 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 15/07/2014 05:07, Nico Weber wrote:<div class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Mon, Jul 14, 2014 at 4:15 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
Author: alp<br>
Date: Mon Jul 14 18:15:48 2014<br>
New Revision: 213010<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=213010&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=213010&view=rev</a><br>
Log:<br>
Define ENABLE_CLANG_ARCMT in the legacy build system too<br>
<br>
<br>
As far as I know, make is just as supported as cmake, no?<br>
</blockquote>
<br></div>
Not really. it hasn't seen any of the feature work CMake has for at least a year. You only need to look at SVN logs to see all the hard work and hours spent on the CMake setup to make it outclass the other setup.<br>
</blockquote><div><br></div><div>Or to see that the CMake build is maintenance for some reason ;-)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Platform support is limited compared to CMake, likewise cross-compilation has been left behind thanks to the remarkable CMake sub-invocation work. No compilation database generation, meaning a poor experience for anyone trying to use tooling on the codebase. Broken dependency scanning, you have to "touch" files or risk getting miscompiles. And there are many Windows developers contributing these days -- their enhancements basically only ever get added to CMake while Makefiles are left with minimal build fixes.<br>
<br>
Then there's bit rot. Various clang tests aren't supported with the 'makefiles' build -- they're simply not run -- the set of installed headers isn't necessarily canonical with makefiles either. Whenever I've pinged that makefiles need to track some change or other, nobody's been too interested in following up. So users really aren't getting the "full LLVM experience" with it at this point, the 'makefiles' bots aren't getting full coverage etc.<br>
<br>
As far as I can tell it would take a large effort to get the traditional build system on par with CMake at this point and nobody's puting in the time to actually do that. While supported, the old system definitely meets the definition of "legacy". Only commits could have changed that, not any amount of hand waving or arguing that it's still the default in "buildit" :-)<br>
</blockquote><div><br></div><div>Sounds like you prefer the cmake build, but there wasn't some thread about this that I missed. So please just say "in make" instead of "legacy build system" (it's more concise, too!)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
<br>
Modified:<br>
cfe/trunk/tools/libclang/<u></u>Makefile<br>
<br>
Modified: cfe/trunk/tools/libclang/<u></u>Makefile<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Makefile?rev=213010&r1=213009&r2=213010&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/tools/<u></u>libclang/Makefile?rev=213010&<u></u>r1=213009&r2=213010&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/tools/libclang/<u></u>Makefile (original)<br>
+++ cfe/trunk/tools/libclang/<u></u>Makefile Mon Jul 14 18:15:48 2014<br>
@@ -37,6 +37,10 @@ ifeq ($(HOST_OS), $(filter $(HOST_OS), L<br>
LLVMLibsOptions += -Wl,-soname,lib$(LIBRARYNAME)$<u></u>(SHLIBEXT)<br>
endif<br>
<br>
+ifeq ($(ENABLE_CLANG_ARCMT),1)<br>
+ CXX.Flags += -DCLANG_ENABLE_ARCMT<br>
+endif<br>
+<br>
##===-------------------------<u></u>------------------------------<u></u>---------------===##<br>
# FIXME: This is copied from the 'lto' makefile. Should we share<br>
this?<br>
##===-------------------------<u></u>------------------------------<u></u>---------------===##<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span></blockquote></div><br></div></div>