<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><blockquote type="cite"><div>On Jul 10, 2014, at 12:46 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 10, 2014 at 12:12 PM, Argyrios Kyrtzidis <span dir="ltr"><<a href="mailto:akyrtzi@gmail.com" target="_blank">akyrtzi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">> On Jul 10, 2014, at 11:51 AM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br>
><br>
> On Thu, Jul 10, 2014 at 11:47 AM, Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>> wrote:<br>
>><br>
>>> On Jul 9, 2014, at 10:07 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br>
>>><br>
>>> Seems like an odd API to expose out of the driver. Perhaps move it to<br>
>>> Triple and do something there? Other API choices?<br>
>><br>
>> Since this was implemented in the clang driver I don’t see a compelling reason to move it but I have no objection either.<br>
><br>
> It was implemented as a helper function, not a formal API in the<br>
> driver. It's not a driver level function and you're basically exposing<br>
> a code generation function as part of the driver. It doesn't make a<br>
> lot of sense there. That's why I was suggesting in the support library<br>
> alongside Triple. We already have a dependence upon Triple in clang so<br>
> we wouldn't be adding anything new. If you want this exported I think<br>
> that's the best place to do so.<br>
<br>
</div>I appreciate the feedback but it will be low on my TODO list for API refactoring for this, if you or anyone else wants to refactor it feel free.</blockquote></div><div class="gmail_extra"><br></div>Argiris, this is reasonable, minor, and easily addressed code review. I know you may have a lot of things on your plate, but *especially* when contributing patches purely to support out-of-tree targets that others don't know about, I think it is really important to promptly address any post-commit review you receive.<br>
<br></div></div>
</div></blockquote></div><div><br></div><div>Ok, will do.</div></body></html>