<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 9, 2014 at 12:06 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class=""><br>
On 09/07/2014 18:48, David Majnemer wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I don't think that MSVC compat is the right predicate here, this has more to do with targeting the msvc environment.<br>
</blockquote>
<br></div>
We're planning go over these soon and switch them to a more appropriate flag like GCCCompat, which will generally be set to !MSVCCompat</blockquote><div><br></div><div>Yes please!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-- so Ehsan's approach is fine for now and easy to move to the new scheme when needed.<br></blockquote><div><br></div><div>So should I proceed with the patch as is?<br></div><div><br clear="all"><div>--<br>Ehsan<br><<a href="http://ehsanakhgari.org/">http://ehsanakhgari.org/</a>></div>
<br></div></div></div></div>