<div dir="ltr">I assume, ensured this script still works by simulating a test failure?<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 8, 2014 at 6:15 PM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Tue Jul  8 11:15:48 2014<br>
New Revision: 212546<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=212546&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=212546&view=rev</a><br>
Log:<br>
Use explicit if and restore lost FileCheck error code checking.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=212546&r1=212545&r2=212546&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=212546&r1=212545&r2=212546&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh Tue Jul  8 11:15:48 2014<br>
@@ -8,5 +8,7 @@ TEMPORARY_FILE=$3.cpp<br>
<br>
 grep -Ev "// *[A-Z-]+:" ${INPUT_FILE} > ${TEMPORARY_FILE}<br>
 clang-tidy ${TEMPORARY_FILE} -fix --checks="-*,${CHECK_TO_RUN}" -- --std=c++11 > ${TEMPORARY_FILE}.msg 2>&1<br>
-FileCheck -input-file=${TEMPORARY_FILE} ${INPUT_FILE} -strict-whitespace<br>
-not grep CHECK-MESSAGES ${INPUT_FILE} || FileCheck -input-file=${TEMPORARY_FILE}.msg ${INPUT_FILE} -check-prefix=CHECK-MESSAGES<br>
+FileCheck -input-file=${TEMPORARY_FILE} ${INPUT_FILE} -strict-whitespace || exit $?<br>
+if grep CHECK-MESSAGES ${INPUT_FILE}; then<br>
+  FileCheck -input-file=${TEMPORARY_FILE}.msg ${INPUT_FILE} -check-prefix=CHECK-MESSAGES || exit $?<br>
+fi<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>
</div></div>