<div dir="ltr"><div>Yes, There was a sample test case on the code review page under test plan.<br><br><a href="http://reviews.llvm.org/D4330">http://reviews.llvm.org/D4330</a><br><br></div>Eric<br><div><div class="gmail_extra">
<br><div class="gmail_quote">On Mon, Jun 30, 2014 at 9:53 AM, Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">----- Original Message -----<br>
> From: "Marshall Clow" <<a href="mailto:mclow.lists@gmail.com">mclow.lists@gmail.com</a>><br>
> To: <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> Sent: Monday, June 30, 2014 10:35:09 AM<br>
> Subject: [libcxx] r212046 - Fix a typo in the noexcept calculation for        __compressed_pair::swap. Thanks to EricWF for<br>
> the bug report and the        fix.<br>
><br>
> Author: marshall<br>
> Date: Mon Jun 30 10:35:09 2014<br>
> New Revision: 212046<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=212046&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=212046&view=rev</a><br>
> Log:<br>
> Fix a typo in the noexcept calculation for __compressed_pair::swap.<br>
> Thanks to EricWF for the bug report and the fix.<br>
<br>
</div>This is testable, right?<br>
<br>
 -Hal<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Modified:<br>
>     libcxx/trunk/include/memory<br>
><br>
> Modified: libcxx/trunk/include/memory<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/memory?rev=212046&r1=212045&r2=212046&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/memory?rev=212046&r1=212045&r2=212046&view=diff</a><br>

> ==============================================================================<br>
> --- libcxx/trunk/include/memory (original)<br>
> +++ libcxx/trunk/include/memory Mon Jun 30 10:35:09 2014<br>
> @@ -2019,7 +2019,7 @@ public:<br>
><br>
>      _LIBCPP_INLINE_VISIBILITY void<br>
>      swap(__libcpp_compressed_pair_imp& __x)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>      {<br>
>          using _VSTD::swap;<br>
>          swap(__first_, __x.__first_);<br>
> @@ -2110,7 +2110,7 @@ public:<br>
><br>
>      _LIBCPP_INLINE_VISIBILITY void<br>
>      swap(__libcpp_compressed_pair_imp& __x)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>      {<br>
>          using _VSTD::swap;<br>
>          swap(__second_, __x.__second_);<br>
> @@ -2203,7 +2203,7 @@ public:<br>
><br>
>      _LIBCPP_INLINE_VISIBILITY void<br>
>      swap(__libcpp_compressed_pair_imp& __x)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>      {<br>
>          using _VSTD::swap;<br>
>          swap(__first_, __x.__first_);<br>
> @@ -2292,7 +2292,7 @@ public:<br>
><br>
>      _LIBCPP_INLINE_VISIBILITY void<br>
>      swap(__libcpp_compressed_pair_imp&)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>      {<br>
>      }<br>
>  };<br>
> @@ -2375,7 +2375,7 @@ public:<br>
><br>
>      _LIBCPP_INLINE_VISIBILITY void swap(__compressed_pair& __x)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>          {base::swap(__x);}<br>
>  };<br>
><br>
> @@ -2384,7 +2384,7 @@ inline _LIBCPP_INLINE_VISIBILITY<br>
>  void<br>
>  swap(__compressed_pair<_T1, _T2>& __x, __compressed_pair<_T1, _T2>&<br>
>  __y)<br>
>          _NOEXCEPT_(__is_nothrow_swappable<_T1>::value &&<br>
> -                   __is_nothrow_swappable<_T1>::value)<br>
> +                   __is_nothrow_swappable<_T2>::value)<br>
>      {__x.swap(__y);}<br>
><br>
>  // __same_or_less_cv_qualified<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Hal Finkel<br>
Assistant Computational Scientist<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div></div>