<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 30, 2014 at 9:31 PM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
LGTM<br>
<br>
BTW Ehsan, your mail looks like a reply to itself and doesn't reference my Message-Id for threading, nor is the To or CC addressed to me in any way so I had no way of knowing you replied other than spotting it on the list archive.<br>

<br>
Manuel, could you update the website-based review guideline to indicate that submitters should include on-list reviewers in their replies?</blockquote><div><br></div><div>The original email and the reply have the same Thread-Index - your email doesn't have one (I know it's non-standard, but last time I checked I didn't find a widely supported standard) - Message-ID is afaik a unique identifier (<a href="http://en.wikipedia.org/wiki/Message-ID">http://en.wikipedia.org/wiki/Message-ID</a>). What am I missing?</div>
<div><br></div><div>Cheers,</div><div>/Manuel</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
<br>
Alp.</font></span><div><div class="h5"><br>
<br>
<br>
<br>
On 30/06/2014 22:55, Ehsan Akhgari wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="h5">
Moved the test.<br>
<br>
<a href="http://reviews.llvm.org/D4350" target="_blank">http://reviews.llvm.org/D4350</a><br>
<br>
Files:<br>
   lib/Frontend/InitPreprocessor.<u></u>cpp<br>
   test/Preprocessor/predefined-<u></u>macros.c<br>
<br>
Index: lib/Frontend/InitPreprocessor.<u></u>cpp<br>
==============================<u></u>==============================<u></u>=======<br>
--- lib/Frontend/InitPreprocessor.<u></u>cpp<br>
+++ lib/Frontend/InitPreprocessor.<u></u>cpp<br>
@@ -433,7 +433,7 @@<br>
    // Initialize language-specific preprocessor defines.<br>
      // Standard conforming mode?<br>
-  if (!LangOpts.GNUMode)<br>
+  if (!LangOpts.GNUMode && !LangOpts.MSVCCompat)<br>
      Builder.defineMacro("__STRICT_<u></u>ANSI__");<br>
      if (LangOpts.CPlusPlus11)<br>
Index: test/Preprocessor/predefined-<u></u>macros.c<br>
==============================<u></u>==============================<u></u>=======<br>
--- test/Preprocessor/predefined-<u></u>macros.c<br>
+++ test/Preprocessor/predefined-<u></u>macros.c<br>
@@ -9,6 +9,7 @@<br>
  // CHECK-MS: #define _M_IX86_FP<br>
  // CHECK-MS: #define _WIN32 1<br>
  // CHECK-MS-NOT: #define __GNUC__<br>
+// CHECK-MS-NOT: #define __STRICT_ANSI__<br>
  //<br>
  // RUN: %clang_cc1 %s -E -dM -ffast-math -o - \<br>
  // RUN:   | FileCheck %s --check-prefix=CHECK-FAST-MATH<br>
<br>
<br></div></div><div class="">
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</div></blockquote><div class=""><div class="h5">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</div></div></blockquote></div><br></div></div>