<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jun 25, 2014 at 2:04 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div class=""><div><br></div></div><div>This is a C++11 feature:</div><div><br></div><div>struct A;</div><div>struct B {</div><div>Â friend A; // note, not 'friend struct A;'</div>
<div>};</div></div></div></div></blockquote><div><br></div><div>You're right, not sure how I missed this as I have a test for this case.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Should be:</div><div><br></div><div>
template<typename> struct C {};</div><div>struct D {</div><div>Â template<> friend struct C<int>;</div><div>};</div><div><br></div><div>(That's ill-formed, but our error recovery path treats it as if it didn't have the 'template<>'.) If that doesn't hit that codepath, I think it may be unreachable.</div>
</div></div></div></blockquote><div><br></div><div>Nope, that one is handled in ActOnClassTemplateSpecialization. I think that this code is unreachable...</div><div><br></div><div>I still need you to OK my changes before I commit them. </div>
</div></div></div>