<div dir="ltr">Couldn't LLVM expose a registry interface on Windows and then the front-end could conditionally include this header on Windows?  Other users of LLVM might wish to use the registry too.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 24, 2014 at 1:11 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">IMO it's OK to use windows.h directly in this case.  There's no sensible cross-platform interface to the registry that we could add to lib/Support.  The registry only exists on Windows.</div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 24, 2014 at 10:11 AM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div><div>On Tue, Jun 24, 2014 at 1:09 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>> wrote:<br>
><br>
> On 24/06/2014 19:53, Aaron Ballman wrote:<br>
>><br>
>> On Tue, Jun 24, 2014 at 12:18 PM, Logan Chien <<a href="mailto:tzuhsiang.chien@gmail.com" target="_blank">tzuhsiang.chien@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> Author: logan<br>
>>> Date: Tue Jun 24 11:18:10 2014<br>
>>> New Revision: 211604<br>
>>><br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=211604&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=211604&view=rev</a><br>
>>> Log:<br>
>>> Use lowercase windows.h for mingw cross compilation.<br>
>>><br>
>>> Modified:<br>
>>>      cfe/trunk/lib/Driver/WindowsToolChain.cpp<br>
>>><br>
>>> Modified: cfe/trunk/lib/Driver/WindowsToolChain.cpp<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/WindowsToolChain.cpp?rev=211604&r1=211603&r2=211604&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/WindowsToolChain.cpp?rev=211604&r1=211603&r2=211604&view=diff</a><br>


>>><br>
>>> ==============================================================================<br>
>>> --- cfe/trunk/lib/Driver/WindowsToolChain.cpp (original)<br>
>>> +++ cfe/trunk/lib/Driver/WindowsToolChain.cpp Tue Jun 24 11:18:10 2014<br>
>>> @@ -30,7 +30,7 @@<br>
>>>     #define WIN32_LEAN_AND_MEAN<br>
>>>     #define NOGDI<br>
>>>     #define NOMINMAX<br>
>>> -  #include <Windows.h><br>
>>> +  #include <windows.h><br>
>>>   #endif<br>
>><br>
>> Why is windows.h being included here instead of WindowsSupport.h?<br>
><br>
><br>
> WindowsSupport.h is internal to LLVM at the moment. We probably don't need<br>
> it for the limited uses of windows.h in the frontend.<br>
<br>
</div></div>That's reasonably fair, but I think getting any instances of Windows.h<br>
out of the frontend would be a very good thing. Obviously, that has no<br>
bearing on this patch. :-)<br>
<div><div><br>
~Aaron<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>