<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 23, 2014 at 2:08 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank" class="cremed">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: lib/CodeGen/CGDebugInfo.cpp:378<br>
@@ -377,2 +377,3 @@<br>
CGM.getCodeGenOpts().DwarfDebugFlags, RuntimeVers, SplitDwarfFilename,<br>
- DebugKind == CodeGenOptions::DebugLineTablesOnly<br>
+ (DebugKind == CodeGenOptions::DebugLineTablesOnly ||<br>
+ DebugKind == CodeGenOptions::LocTrackingOnly)<br>
----------------<br>
I'd use <= here, though it doesn't really matter since this metadata should never end up being read/used in the LocTrackingOnly situation.<br></blockquote><div><br></div><div>Done.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
================<br>
Comment at: lib/Frontend/CompilerInvocation.cpp:571<br>
@@ +570,3 @@<br>
+ Opts.setDebugInfo(CodeGenOptions::LocTrackingOnly);<br>
+ Opts.DebugColumnInfo = true;<br>
+ }<br>
----------------<br>
You only want to track column info if the user didn't request debug info? That seems like a strange limitation - the diagnostic quality will improve/change in non-debug builds?<br></blockquote><div><br></div><div>Yeah. I forgot to comment about this one. I am not sure what to do when the user requests debug info. If I force column tracking, I will be changing the output when -Rpass is used. I was hesitant about trying to introduce a tracking-only option for column info, as that seems more convoluted than what I have now.</div>
<div><br></div><div>My question then. Does it matter if -Rpass forces column-info on a regular debug build? Other than the .loc entries having non-zero column indicators, I didn't notice any other change. Not sure how much we want to avoid that, though.</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
================<br>
Comment at: test/Frontend/optimization-remark.c:11<br>
@@ +10,3 @@<br>
+// -Rpass should produce source location annotations.<br>
+// CHECK: , !dbg !<br>
+//<br>
----------------<br>
You should be able to test for the absence of any type information, for example (at a guess: CHECK-NOT: DW_TAG_basic_type) now that you've changed those couple of == GMLT to <= GMLT. If you undo those changes, add the CHECK-NOT I mentioned, verify the test fails, then reapply the changes, that'd be great.<br>
</blockquote><div><br></div><div>Indeed. I added a test for DW_TAG_base_type to the test.</div><div><br></div><div><br></div><div>Diego.</div></div></div></div>