<div dir="ltr">Problems were reported on the original commit thread. The revert commit log would do well to mention that along with the revision number rather than a hash....</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Jun 13, 2014 at 2:02 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
why?<br>
<div class="HOEnZb"><div class="h5"><br>
On 12 June 2014 19:19, David Fang <<a href="mailto:fang@csl.cornell.edu">fang@csl.cornell.edu</a>> wrote:<br>
> Author: fangism<br>
> Date: Thu Jun 12 18:19:55 2014<br>
> New Revision: 210857<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210857&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210857&view=rev</a><br>
> Log:<br>
> Revert "fixes duplicate header installation"<br>
><br>
> This reverts commit 0bd40d6c3da6719fecf77038673d453ff1eab25b.<br>
><br>
> Modified:<br>
>     libcxx/trunk/CMakeLists.txt<br>
><br>
> Modified: libcxx/trunk/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=210857&r1=210856&r2=210857&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=210857&r1=210856&r2=210857&view=diff</a><br>

> ==============================================================================<br>
> --- libcxx/trunk/CMakeLists.txt (original)<br>
> +++ libcxx/trunk/CMakeLists.txt Thu Jun 12 18:19:55 2014<br>
> @@ -123,9 +123,13 @@ macro(setup_abi_lib abipathvar abidefine<br>
>        message(FATAL_ERROR "Failed to find ${fpath}")<br>
>      endif()<br>
>    endforeach()<br>
> +  add_custom_target(abilib_headers DEPENDS ${LIBCXX_CXX_ABI_DEPS})<br>
> +  set(LIBCXX_CXX_ABI_DEPS abilib_headers)<br>
>    include_directories("${CMAKE_BINARY_DIR}/include")<br>
> -  install(FILES ${LIBCXX_CXX_ABI_DEPS}<br>
> +  install(DIRECTORY "${CMAKE_BINARY_DIR}/include/"<br>
>      DESTINATION include/c++/v1<br>
> +    FILES_MATCHING<br>
> +    PATTERN "*"<br>
>      )<br>
>  endmacro()<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>