<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 12, 2014 at 11:22 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><p dir="ltr"><br>
On 12 Jun 2014 10:57, "Saleem Abdulrasool" <<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>> wrote:<br>
><br>
> Author: compnerd<br>
> Date: Thu Jun 12 12:43:37 2014<br>
> New Revision: 210804<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=210804&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=210804&view=rev</a><br>
> Log:<br>
> Basic: fix warnings from GCC<br>
><br>
> tools/clang/lib/Basic/DiagnosticIDs.cpp: In function ‘clang::DiagnosticIDs::Level toLevel(clang::diag::Severity)’:<br>
> tools/clang/lib/Basic/DiagnosticIDs.cpp:382:1: warning: control reaches end of non-void function [-Wreturn-type]<br>
><br>
> tools/clang/lib/Format/Format.cpp: In member function ‘virtual std::string clang::format::ParseErrorCategory::message(int) const’:<br>
> tools/clang/lib/Format/Format.cpp:282:1: warning: control reaches end of non-void function [-Wreturn-type]<br>
><br>
> Add a default cases that asserts that we handle the severity, parse error.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Basic/DiagnosticIDs.cpp<br>
>     cfe/trunk/lib/Format/Format.cpp<br>
><br>
> Modified: cfe/trunk/lib/Basic/DiagnosticIDs.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/DiagnosticIDs.cpp?rev=210804&r1=210803&r2=210804&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/DiagnosticIDs.cpp?rev=210804&r1=210803&r2=210804&view=diff</a><br>


> ==============================================================================<br>
> --- cfe/trunk/lib/Basic/DiagnosticIDs.cpp (original)<br>
> +++ cfe/trunk/lib/Basic/DiagnosticIDs.cpp Thu Jun 12 12:43:37 2014<br>
> @@ -368,6 +368,7 @@ StringRef DiagnosticIDs::getDescription(<br>
><br>
>  static DiagnosticIDs::Level toLevel(diag::Severity SV) {<br>
>    switch (SV) {<br>
> +  default: llvm_unreachable("unexpected severity");</p>
</div><p dir="ltr">The 'unreachable' call for a covered switch (in which every case returns) should go after the switch, not in a default: case, so we get a diagnostic if a new enumerator is added but isn't handled here.</p>
</blockquote><div>Forgot to mention, addressed in SVN r210812.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr"><span style="color:rgb(80,0,80)">>    case diag::Severity::Ignored:</span></p>
<div class="HOEnZb"><div class="h5"><p dir="ltr">
>      return DiagnosticIDs::Ignored;<br>
>    case diag::Severity::Remark:<br>
><br>
> Modified: cfe/trunk/lib/Format/Format.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=210804&r1=210803&r2=210804&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=210804&r1=210803&r2=210804&view=diff</a><br>


> ==============================================================================<br>
> --- cfe/trunk/lib/Format/Format.cpp (original)<br>
> +++ cfe/trunk/lib/Format/Format.cpp Thu Jun 12 12:43:37 2014<br>
> @@ -272,6 +272,7 @@ const char *ParseErrorCategory::name() c<br>
><br>
>  std::string ParseErrorCategory::message(int EV) const {<br>
>    switch (static_cast<ParseError>(EV)) {<br>
> +  default: llvm_unreachable("unexpected parse error");<br>
>    case ParseError::Success:<br>
>      return "Success";<br>
>    case ParseError::Error:<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</p>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div>