<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><br><div><div>On Jun 5, 2014, at 6:00 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jun 4, 2014 at 8:18 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Wed, Jun 4, 2014 at 7:57 PM, Tyler Nowicki <span dir="ltr"><<a href="mailto:tnowicki@apple.com" target="_blank">tnowicki@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Aaron and Richard,<br>
<br>
Thanks for the review and putting up with me while I learn clang! Here is the patch with your changes.<br>
<div><br>
<br>
>> + // Vectorization/interleaving is disabled, set width/count to 1.<br>
>> + ValueInt = 1;<br>
>> + // Fallthrough.<br>
><br>
> We should add [[clang::fallthrough]] to Compiler.h and use it here. :-)<br>
<br>
</div>Turns out I didn’t need to make any changes to Compiler.h. It works fine for me. Will it work for all builds?<br></blockquote><div><br></div></div></div><div>Unlikely. MSVC's table of C++11 lists attributes as unsupported:</div>
<div><a href="http://msdn.microsoft.com/en-us/library/hh567368.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/hh567368.aspx</a></div><div><br></div><div>GCC is also likely to warn on unrecognized attributes, which wouldn't work.</div>
</div></div></div>
</blockquote></div><br></div><div class="gmail_extra">A change to add [[clang::fallthrough]] to Compiler.h should not be part of this patch. Please go ahead with this as-is, and we can deal with the fallthrough macro part separately.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">IIRC, Richard Trieu sent out a patch quite a while ago adding a fallthrough macro to Compiler.h (along with patches to Clang and LLVM to use it). I don't call what happened to that.</div>
</div>
</blockquote></div><br></body></html>