<div dir="ltr">Hi Nick,<div><br></div><div>I'm slightly confused at the semantics of the defines. In my head, "zero cost" versus SJLJ are one dimension. Then within ZeroCost, there's the Itanium ABI (with DWARF encoding) and the Arm EABI (with EHABI encoding).</div>
<div><br></div><div>Thus, I would have expected __arm__ to be both "zero cost" as well as EHABI.</div><div><br></div><div>Is my understanding incorrect? (It very well may be...)</div><div><div><br></div><div>-Albert <br>
</div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 3, 2014 at 11:50 PM, Jonathan Roelofs <span dir="ltr"><<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nick,<br>
<br>
This combines with Logan's work, and implements the libunwind bits that Logan's patch relied on libgcc_s for, in order to get rid of that dependency.<br>
<br>
Jon<div><div class="h5"><br>
<br>
On 6/3/14, 3:47 PM, Nick Kledzik wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
Dana,<br>
<br>
Is this a separate implementation of ARM EHABI than what Logan proposed<br>
4/13/2014? Or is this this same, but broken into steps?<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ }<br>
+ #define _LIBUNWIND_BUILD_ZERO_COST_<u></u>APIS (__i386__ || __x86_64__ ||<br>
__arm64__ || __arm__)<br>
+ #define _LIBUNWIND_BUILD_SJLJ_APIS 0<br>
+ #define _LIBUNWIND_SUPPORT_FRAME_APIS (__i386__ || __x86_64__)<br>
+ #define _LIBUNWIND_EXPORT __attribute__((visibility("<u></u>default")))<br>
+ #define _LIBUNWIND_HIDDEN __attribute__((visibility("<u></u>hidden")))<br>
+ #define _LIBUNWIND_LOG(msg, ...) fprintf(stderr, "libuwind: " msg, __VA_ARGS__)<br>
+ #define _LIBUNWIND_ABORT(msg) assert_rtn(__func__, __FILE__, __LINE__, msg)<br>
+<br>
+ #define _LIBUNWIND_SUPPORT_COMPACT_<u></u>UNWIND 0<br>
+ #define _LIBUNWIND_SUPPORT_DWARF_<u></u>UNWIND 0<br>
+ #define _LIBUNWIND_SUPPORT_DWARF_INDEX 0<br>
+ #define _LIBUNWIND_SUPPORT_ARM_EHABI_<u></u>UNWIND 1<br>
#endif<br>
</blockquote>
There will be three unwinding models: zero-cost, sj-lj, and EHABI. So there<br>
should be three mutually exclusive build settings:<br>
_LIBUNWIND_BUILD_ZERO_COST_<u></u>APIS<br>
_LIBUNWIND_BUILD_SJLJ_APIS<br>
_LIBUNWIND_BUILD_ARM_EHABI_<u></u>APIS<br>
<br>
The SUPPORT_{COMPACT_UNWIND,DWARF_<u></u>UNWIND,DWARF_INDEX} were intended as ways that<br>
zero-cost unwind information could be encoded.<br>
<br>
The patch above turns on both _LIBUNWIND_BUILD_ZERO_COST_<u></u>APIS for all<br>
architectures, which is wrong. It also leaves _LIBUNWIND_BUILD_ZERO_COST_<u></u>APIS<br>
true for __arm__ which is probably wrong too.<br>
<br>
-Nick<br>
<br>
<br>
On Jun 2, 2014, at 5:48 AM, Dana Jansens <<a href="mailto:danakj@google.com" target="_blank">danakj@google.com</a><br></div></div><div class="">
<mailto:<a href="mailto:danakj@google.com" target="_blank">danakj@google.com</a>>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Nick,<br>
<br>
Can you please take a look at this patch? With this, we define an<br>
UnwindInfoSections for ARM EHABI and are able to populate it.<br>
<br>
We'll start making use of this in future patches, as Albert laid out here:<br>
<a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140526/106670.html" target="_blank">http://lists.cs.uiuc.edu/<u></u>pipermail/cfe-commits/Week-of-<u></u>Mon-20140526/106670.html</a><br>
<br>
This patch builds and passes tests on Mac.<br>
<br>
Thanks,<br>
Dana<br>
<ehabi_address_space.diff><br>
</blockquote>
<br>
</div></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
Jon Roelofs<br>
<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
</font></span></blockquote></div><br></div></div></div></div>