<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Jun 2, 2014, at 1:11 AM, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:<br><div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Ping.</div></blockquote><div><br></div>Please make this test pass under C++03, and then commit.</div><div><br></div><div>— Marshall</div><div><br><blockquote type="cite"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 30, 2014 at 4:43 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The attached patch implements your suggestion (without the max). I verified that this passes on x86 os x and arm android.</div>
<div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 4:25 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Wed, May 28, 2014 at 4:04 PM, Marshall Clow <span dir="ltr"><<a href="mailto:mclow.lists@gmail.com" target="_blank">mclow.lists@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><br>
On May 28, 2014, at 4:36 AM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:<br>
<br>
> Hi,<br>
><br>
> On arm, the maxium alignment is 8. The attached patch tweaks meta.trans.other/aligned_storage.pass.cpp so that it passes on arm. (The test currently assumes that alignment goes up to at least 16.)<br>
<br>
</div>Nico —<br>
<br>
I’m a bit leery of<br>
+ static_assert(std::alignment_of<T1>::value == alignof(T1), "");<br>
b/c I’m not sure that it tests what we want to test here.<br>
<br>
Is there some way that we can use max_align_t in this test?<br>
<br>
Maybe something like (untested code):<br>
static_assert ( std::alignment_of<T1>::value == std::max(16, alignof(std::max_align_t));<br></blockquote><div><br></div></div><div>Why the max? On arm, alignof(max_align_t) is 8 (just like alignof(T1)), so max(16, alignof(max_aling_t)) is 16, while std::alignment_of<T1>::value is 8.</div>
<div><br></div><div><div> static_assert(std::alignment_of<T1>::value ==</div><div> alignof(std::max_align_t), "");</div></div><div><br></div><div>does work though, if you like that better. Should I just s/alignof(T1)/alignof(std::max_align_t)/ in my patch?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
— Marshall<br>
<br>
</blockquote></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</blockquote></div><br></body></html>