I can't commit the change to the repository. Can anyone else do it for us?<div><br></div><div>the lines I commented out may be unnecessary in the macro which deals with c++abi headers. Should those lines be deleted?<br>
<br>On Friday, May 23, 2014, İsmail Dönmez <<a href="mailto:ismail@donmez.ws">ismail@donmez.ws</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">
This fixes the double-installed headers. Can this be applied please?<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 22, 2014 at 2:24 AM, Ryuta Suzuki <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','ryuuta@gmail.com');" target="_blank">ryuuta@gmail.com</a>></span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Commenting out the install in "setup_abi_lib" macro worked for me:</div><div><br></div><div>


Index: llvm/projects/libcxx/CMakeLists.txt</div><div>===================================================================</div>
<div>--- llvm/projects/libcxx/CMakeLists.txt (revision 209334)</div><div>+++ llvm/projects/libcxx/CMakeLists.txt (working copy)</div><div>@@ -126,11 +126,11 @@</div><div>   add_custom_target(abilib_headers DEPENDS ${LIBCXX_CXX_ABI_DEPS})</div>



<div>   set(LIBCXX_CXX_ABI_DEPS abilib_headers)</div><div>   include_directories("${CMAKE_BINARY_DIR}/include")</div><div>-  install(DIRECTORY "${CMAKE_BINARY_DIR}/include/"</div><div>-    DESTINATION include/c++/v1</div>



<div>-    FILES_MATCHING</div><div>-    PATTERN "*"</div><div>-    )</div><div>+#  install(DIRECTORY "${CMAKE_BINARY_DIR}/include/"</div><div>+#    DESTINATION include/c++/v1</div><div>+#    FILES_MATCHING</div>



<div>+#    PATTERN "*"</div><div>+#    )</div><div> endmacro()</div><div><br></div><div> if ("${LIBCXX_CXX_ABI}" STREQUAL "libstdc++" OR</div><div><br></div></div><div class="gmail_extra"><br>



<br><div class="gmail_quote"><div><div>On Wed, May 21, 2014 at 5:22 PM, İsmail Dönmez <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','ismail@donmez.ws');" target="_blank">ismail@donmez.ws</a>></span> wrote:<br>
</div></div>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
<div dir="ltr">Hi,<div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Mon, May 5, 2014 at 11:14 PM, David Fang <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','fang@csl.cornell.edu');" target="_blank">fang@csl.cornell.edu</a>></span> wrote:<br>





<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">ping.<br>
<br>
Would be helpful if someone cmake-literate could review,<br>
and if someone could test on !darwin.<br></blockquote><div><br></div></div><div>Tested this on Linux but I still get duplicated headers installed:</div><div><br></div><div> [   35s] libcxx.x86_64: W: files-duplicate /usr/include/c++/v1/c++/v1/__tuple_03 /usr/include/c++/v1/__tuple_03</div>





<div>[   35s] libcxx.x86_64: W: files-duplicate /usr/include/c++/v1/c++/v1/__split_buffer /usr/include/c++/v1/__split_buffer</div><div>[   35s] libcxx.x86_64: W: files-duplicate /usr/include/c++/v1/strstream /usr/include/c++/v1/c++/v1/strstream</div>





<div>[   35s] libcxx.x86_64: W: files-duplicate /usr/include/c++/v1/c++/v1/random /usr/include/c++/v1/random</div><div>[   35s] libcxx.x86_64: W: files-duplicate /usr/include/c++/v1/cstring /usr/include/c++/v1/c++/v1/cstring</div>





<div>and a lot more of that.</div><div><br></div></div></div></div>
<br></div></div><div>_______________________________________________<br>
cfe-dev mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','cfe-dev@cs.uiuc.edu');" target="_blank">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
<br></div></blockquote></div><br></div>
</blockquote></div><br></div></div>
</blockquote></div>