<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>If this was a fix for clang’s code (IR) generation or an llvm optimization, it would make sense to test the IR. I felt it was a little odd to test the IR for a fix in one of the header files, since the mistake doesn’t involve clang’s code-gen. </div><div><br></div><div>If I were to write an IR test, I would probably check the string “_mm_packs_pi32”. I don’t know if this is possible, but wouldn’t it be better to somehow test the string “_mm_packs_pi32” in the source code (using clang -E)?</div><div><br></div><div><div>On May 22, 2014, at 9:29 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, May 22, 2014 at 10:27 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanaka@apple.com" target="_blank">ahatanaka@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>I thought about adding a test case, but wasn’t sure how this fix should be tested.</div>
<div><br></div><div>I don’t think it’s a good idea to check the bitcode clang generates, is it?</div></div></blockquote><div><br></div><div>We routinely test the generated IR (without optimizations)?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div class="h5"><br><div><div>On May 22, 2014, at 8:35 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 22, 2014 at 6:38 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanaka@apple.com" target="_blank">ahatanaka@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;"><div style="overflow:hidden">Author: ahatanak<br>
Date: Thu May 22 19:38:07 2014<br>
New Revision: 209489<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=209489&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=209489&view=rev</a><br>
Log:<br>
Fix a bug in xmmintrin.h.<br>
<br>
The last step of _mm_cvtps_pi16 should use _mm_packs_pi32, which is a function<br>
that reads two __m64 values and packs four 32-bit values into four 16-bit<br>
values.</div></blockquote></div><br>This (somewhat obviously) needs a test case.</div></div>
</blockquote></div><br></div></div></blockquote></div><br></div></div>
</blockquote></div><br></body></html>