<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Perhaps if we generalized the part that adds metadata to the loop so attributes and non-attributes (openmp stmts) can use the same mechanism? I’m not sure how other aspects are compatible. I would have to think about it.</div><div><br></div><div>I’ll work on a patch to merge these mechanisms in a follow-up commit.</div><div><br></div><div>Tyler</div><div><br></div><div><div>On May 22, 2014, at 2:27 AM, Alexander Musman <<a href="mailto:alexander.musman@gmail.com">alexander.musman@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div><span style="font-size:12.800000190734863px;font-family:arial,sans-serif">I've just committed my change with emission of the loop metadata for vectorizer for 'omp simd' (in r</span><font face="arial, sans-serif">209411</font><span style="font-size:12.800000190734863px;font-family:arial,sans-serif">) and </span><span style="font-size:12.800000190734863px;font-family:arial,sans-serif">I think that in some follow-up patch it would be good to do a change to use the same code path in both (i.e. use CGLoopInfo to emit loop metadata for all vectorizing pragmas). Actually, if '#pragma loop vectorize' will get a clause for marking loads/stores loop-parallel, it is good idea to reuse it anyway.</span></div>
<div><br></div><div><font face="arial, sans-serif">Alexander</font></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-05-20 20:12 GMT+04:00 Tyler Nowicki <span dir="ltr"><<a href="mailto:tnowicki@apple.com" target="_blank">tnowicki@apple.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping.<br>
<div><div class="h5"><br>
On May 14, 2014, at 10:05 AM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br>
<br>
> Hi Alexey, Aaron,<br>
><br>
> Thanks for the review. Richard and John please review the attached patch.<br>
><br>
> Tyler<br>
><br>
</div></div>> <pragma_loop-svn.patch><br>
<div class="im HOEnZb">><br>
> On May 13, 2014, at 9:51 PM, Alexey Bataev <<a href="mailto:a.bataev@hotmail.com">a.bataev@hotmail.com</a>> wrote:<br>
><br>
>> I think CodeGen part of the patch should be reviewed by John McCall.<br>
<br>
</div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></body></html>