<div dir="ltr">Did you forget to add the helper function rename? They appear to still be uppercase.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 19, 2014 at 1:23 AM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: djasper<br>
Date: Mon May 19 02:23:03 2014<br>
New Revision: 209111<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=209111&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=209111&view=rev</a><br>
Log:<br>
Address review comments on r208954. No functional changes.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp?rev=209111&r1=209110&r2=209111&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp?rev=209111&r1=209110&r2=209111&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp Mon May 19 02:23:03 2014<br>
@@ -88,9 +88,9 @@ void UseOverride::check(const MatchFinde<br>
     StringRef ReplacementText = "override ";<br>
<br>
     if (Method->hasAttrs()) {<br>
-      for (const clang::Attr *attr : Method->getAttrs()) {<br>
-        if (!attr->isImplicit()) {<br>
-          InsertLoc = Sources.getExpansionLoc(attr->getLocation());<br>
+      for (const clang::Attr *A : Method->getAttrs()) {<br>
+        if (!A->isImplicit()) {<br>
+          InsertLoc = Sources.getExpansionLoc(A->getLocation());<br>
           break;<br>
         }<br>
       }<br>
@@ -117,11 +117,10 @@ void UseOverride::check(const MatchFinde<br>
   }<br>
<br>
   if (Method->isVirtualAsWritten()) {<br>
-    for (unsigned i = 0, e = Tokens.size(); i != e; ++i) {<br>
-      if (Tokens[i].is(tok::raw_identifier) &&<br>
-          GetText(Tokens[i], Sources) == "virtual") {<br>
+    for (Token Tok : Tokens) {<br>
+      if (Tok.is(tok::raw_identifier) && GetText(Tok, Sources) == "virtual") {<br>
         Diag << FixItHint::CreateRemoval(CharSourceRange::getTokenRange(<br>
-            Tokens[i].getLocation(), Tokens[i].getLocation()));<br>
+            Tok.getLocation(), Tok.getLocation()));<br>
         break;<br>
       }<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>