<div dir="ltr"><div>+bool DeclContext::isStdNamespace(bool IncludeInlineNamespace) const {<br></div><div>[...]</div><div>+  if (!getParent()->getRedeclContext()->isTranslationUnit())</div><div>+    return false;</div>
<div><br></div><div>This returns the wrong result if 'std' is itself in an inline namespace, but I guess we don't need to care about that.</div><div><br></div><div>I think the default of IncludeInlineNamespace should be true, not false. The call in SemaExceptionSpec should set it to 'true', as should all the calls in the static analyzer, and that only leaves the SemaTemplateInstantiateDecl call, where we don't care. Can the parameter be removed altogether?</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 30, 2014 at 3:32 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Take two, with proper diff context this time.<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D3333" target="_blank">http://reviews.llvm.org/D3333</a><br>
<br>
Files:<br>
  include/clang/AST/DeclBase.h<br>
  lib/AST/Decl.cpp<br>
  lib/AST/DeclBase.cpp<br>
  lib/Analysis/Consumed.cpp<br>
  lib/Sema/SemaExceptionSpec.cpp<br>
  lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
  lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp<br>
  lib/StaticAnalyzer/Core/BugReporterVisitors.cpp<br>
  lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp<br>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>