<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 15, 2014, at 11:05 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Thank you for fixing this!</div></blockquote><div><br></div>yes, thanks!</div><div><br></div><div>— Marshall</div><div><br><blockquote type="cite"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 15, 2014 at 6:54 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Fri, May 16, 2014 at 12:11 AM, Marshall Clow <span dir="ltr"><<a href="mailto:mclow.lists@gmail.com" target="_blank">mclow.lists@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><br>
On May 15, 2014, at 10:08 AM, Jeffrey Yasskin <<a href="mailto:jyasskin@google.com" target="_blank">jyasskin@google.com</a>> wrote:<br>
<br>
> I would totally believe those were wrong. They worked around<br>
> <stddef.h> doing something absolutely crazy that I don't remember<br>
> anymore, and it sounds like that's been fixed.<br>
<br>
</div>My only concern is with the initial checkin comment “for ubuntu”.<br>
If this doesn’t break Ubuntu, then I’m good with it.<br></blockquote><div><br></div></div><div>r208942, thanks! I did some light testing on Ubuntu with the patch, and things still seemed to work with it. (And the thing mentioned in PR19723 now works:</div>
<div><br></div><div><div> #include <cstddef></div><div> struct A { int a; };</div><div> int O = offsetof(A, a);</div><div><br></div><div> $ clang -c -stdlib=libc++ -Ipath/to/libcxx/include -std=c++11</div></div>
<div><br></div><div>This was broken without this change, and this is e.g. needed to bootstrap clang.)</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><font color="#888888"><br>
— Marshall<br>
</font></span><div><br>
> On Thu, May 15, 2014 at 5:20 AM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>> wrote:<br>
>> A little SVN digging indicates the change originated in r104516. Removing it<br>
>> cursorily seems OK, CC'ing in Jeffrey Yasskin who wrote it.<br>
>><br>
>> Alp.<br>
>><br>
>><br>
>><br>
>> On 15/05/2014 07:21, Nico Weber wrote:<br>
>>><br>
>>><br>
>>> Ping.<br>
>>><br>
>>><br>
>>> On May 13, 2014 12:05 PM, "Nico Weber" <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a><br>
>>> <mailto:<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>>> wrote:<br>
>>><br>
>>> D'oh, forgot to cc Marshall :-)<br>
>>><br>
>>><br>
>>> On Tue, May 13, 2014 at 12:00 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a><br>
>>> <mailto:<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>>> wrote:<br>
>>><br>
>>> Hi,<br>
>>><br>
>>> r207606 changed the __need_foo macros to behave like they do<br>
>>> with gcc: If they are set, _only_ the __need_foo stuff gets<br>
>>> defined. libc++'s cstddef sets a few __need_foo settings, so<br>
>>> cstddef now doesn't work right with libc++ after clang r207606.<br>
>>><br>
>>> The attached patch removes the __need_foo defines from<br>
>>> libc++'s cstddef. They were added with a cryptic commit<br>
>>> message ""for ubuntu" years ago - I think they're incorrect,<br>
>>> and things still seem to work without them. (libstdc++ doesn't<br>
>>> set them either.) Maybe they were needed before clang had<br>
>>> r207606 - if so, this patch should also improve how libc++<br>
>>> works when built with gcc.<br>
>>><br>
>>> This fixes PR19723, see the bug for some more information and<br>
>>> discussion.<br>
>>><br>
>>> Ok?<br>
>>><br>
>>> Nico<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> cfe-commits mailing list<br>
>>> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
>><br>
>><br>
>> --<br>
>> <a href="http://www.nuanti.com/" target="_blank">http://www.nuanti.com</a><br>
>> the browser experts<br>
>><br>
<br>
</div></blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></body></html>