<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Any reason why the additional test in
invalid-kernel-attrs.cl only tests whether the Z dimension is 0?
Would be useful to ensure no regressions occur that we test each
dimension (Perhaps you could just submit additional testing in a
further review though, no need to hold up this patch any longer -
the patch LGTM otherwise!)<br>
<br>
Cheers,<br>
-Neil.<br>
<br>
On 19/05/2014 11:30, Pedro Ferreira wrote:<br>
</div>
<blockquote cite="mid:5379DD2D.9080300@imgtec.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Any more comments on this?<br>
<br>
On 13/05/14 17:09, Pedro Ferreira wrote:<br>
</div>
<blockquote cite="mid:537243C5.5060703@imgtec.com" type="cite">Your
wish is my command. <br>
<br>
On 13/05/14 16:18, Joey Gouly wrote: <br>
<blockquote type="cite">LGTM too, but please add a test case to
invalid-kernel-attrs.cl. <br>
<br>
-----Original Message----- <br>
From: <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a>
<br>
[<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="mailto:cfe-commits-bounces@cs.uiuc.edu">mailto:cfe-commits-bounces@cs.uiuc.edu</a>]
On Behalf Of David Tweed <br>
Sent: 13 May 2014 11:50 <br>
To: 'Pedro Ferreira'; <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<br>
Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size
requirement of 0 <br>
<br>
The patch LGTM. <br>
-----Original Message----- <br>
From: <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a>
<br>
[<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="mailto:cfe-commits-bounces@cs.uiuc.edu">mailto:cfe-commits-bounces@cs.uiuc.edu</a>]
On Behalf Of Pedro Ferreira <br>
Sent: 13 May 2014 10:03 <br>
To: <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<br>
Subject: [PATCH] Clang: Reject OpenCL workgroup size
requirement of 0 <br>
<br>
OpenCL allows us to define the workgroup size used in a kernel
in order <br>
to further optimise the code, specifically to that size. <br>
The syntax is <br>
__attribute__((reqd_work_group_size(X, Y, Z))) <br>
<br>
where X, Y and Z are compile-time known integers. <br>
Currently clang allows any of those to be 0, which would be
illegal in <br>
OpenCL. <br>
<br>
The attached patch adds this validation; it's currently a
draft and any <br>
comments would be welcome. <br>
<br>
(I reported this on bug 19699) <br>
<br>
<br>
<br>
<br>
_______________________________________________ <br>
cfe-commits mailing list <br>
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
<br>
<br>
<br>
<br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>