<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi Richard,</div><br><div><div>On May 8, 2014, at 1:27 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, May 8, 2014 at 1:20 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div class="">On Thu, May 8, 2014 at 11:09 AM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: benlangmuir<br>
Date: Thu May 8 13:09:29 2014<br>
New Revision: 208345<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208345&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208345&view=rev</a><br>
Log:<br>
Remove -Wnon-modular-include<br>
<br>
But keep -Wnon-modular-include-in-[framework-]module<br>
<br>
This warning is too noisy and doesn't really indicate a problem for most<br>
people. Even though it would only really affect people using<br>
-Weverything, that seems bad so remove it.<br></blockquote><div><br></div></div><div>Wait a second, we were planning on using this to replace -fmodules-strict-decluse. People using -Weverything need to use -Wno-foo for the warnings they don't want; that's the cost of using that option.</div>
</div></div></div></blockquote><div><br></div><div>From when -Weverything was added:<br><br>Eli Friedman wrote:<br>> This seems like a bad idea: people will start using it, then complain<br>> whenever we add a new warning which isn't generically applicable<br>
> (suppose we add an opt-in warning for C-style casts in C++, for<br>> example). We already have -Wextra for people who want lots of> warnings.<br><br>Ted Kremenek responded:<br>[...]<br>> -Weverything is not for everybody, and for those that complain about<br>
> new warnings we can (and should) tell them to take the opt-in approach<br>> as opposed to the opt-out approach. I don't see a problem with really<br>> serving both sets of user preferences.</div><div><br></div>
<div>=> We do not get to use -Weverything as an excuse for removing warning that are noisy and that some users aren't interested in.</div></div></div></div></blockquote><div><br></div><div>This is not just noisy, it has no value IMO. How can we expect an application not to #include something textually and what is the user supposed to do when they see this warning ?</div><br><blockquote type="cite">
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>