<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 5, 2014, at 1:02 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Sorry for the delay!</div><div><br></div>Can you factor out the known header checking, or move it into an 'if', rather than skipping it with a goto?<div><br></div><div>Otherwise, LGTM, thanks!</div></div></blockquote><div><br></div>Thanks for the review, I moved that code under an if, took the opportunity to use a range-based-for and committed as r208004.</div><div><br></div><div>Ben<br><blockquote type="cite"><div dir="ltr">
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, May 4, 2014 at 7:07 PM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">gentle ping<br>
<div><div class="h5"><br>
On Apr 28, 2014, at 8:54 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com">blangmuir@apple.com</a>> wrote:<br>
<br>
> This patch adds the warning options:<br>
><br>
> -Wnon-modular-include -- warn on any #include of a header that's not listed in a module map<br>
> [-Wnon-modular-include-in-module -- subgroup, only warn if the include is in a module]<br>
> -Wnon-modular-include-in-framework-module -- subgroup, only warn if the include is in a framework module<br>
><br>
> There had been discussion of this making -fmodules-strict-decluse redundant, but I wasn’t sure if we came to an agreement about that, so I didn’t remove it.<br>
><br>
><br>
</div></div>> Ben<non-modular-include.patch><br>
><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>