<p dir="ltr">Is there any reason this code is xcore specific? Would've figured the basic debug flags would mostly be covered in some generic way? But I haven't looked. Perhaps there's good reason not to do that.</p>

<div class="gmail_quote">On May 2, 2014 2:43 AM, "Robert Lytton" <<a href="mailto:robert@xmos.com">robert@xmos.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rlytton<br>
Date: Fri May  2 04:33:25 2014<br>
New Revision: 207833<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=207833&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=207833&view=rev</a><br>
Log:<br>
XCore target: fix handling of -g0 flag<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Tools.cpp<br>
    cfe/trunk/test/Driver/xcore-opts.c<br>
<br>
Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207833&r1=207832&r2=207833&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207833&r1=207832&r2=207833&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Tools.cpp Fri May  2 04:33:25 2014<br>
@@ -7622,8 +7622,9 @@ void XCore::Assemble::ConstructJob(Compi<br>
   if (Args.hasArg(options::OPT_v))<br>
     CmdArgs.push_back("-v");<br>
<br>
-  if (Args.hasArg(options::OPT_g_Group))<br>
-    CmdArgs.push_back("-g");<br>
+  if (Arg *A = Args.getLastArg(options::OPT_g_Group))<br>
+    if (!A->getOption().matches(options::OPT_g0))<br>
+      CmdArgs.push_back("-g");<br>
<br>
   if (Args.hasFlag(options::OPT_fverbose_asm, options::OPT_fno_verbose_asm,<br>
                    false))<br>
<br>
Modified: cfe/trunk/test/Driver/xcore-opts.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/xcore-opts.c?rev=207833&r1=207832&r2=207833&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/xcore-opts.c?rev=207833&r1=207832&r2=207833&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/test/Driver/xcore-opts.c (original)<br>
+++ cfe/trunk/test/Driver/xcore-opts.c Fri May  2 04:33:25 2014<br>
@@ -1,6 +1,7 @@<br>
 // RUN: %clang -target xcore %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s<br>
 // RUN: %clang -target xcore -x c++ %s -g -Wl,L1Arg,L2Arg -Wa,A1Arg,A2Arg -fverbose-asm -v -### -o %t.o 2>&1 | FileCheck %s<br>
 // RUN: %clang -target xcore -x c++ %s -fexceptions -### -o %t.o 2>&1 | FileCheck -check-prefix CHECK-EXCEP %s<br>
+// RUN: %clang -target xcore %s -g0 -### -o %t.o 2>&1 | FileCheck -check-prefix CHECK-G0 %s<br>
<br>
 // CHECK: "-nostdsysteminc"<br>
 // CHECK: "-momit-leaf-frame-pointer"<br>
@@ -27,3 +28,7 @@<br>
 // CHECK-EXCEP: xcc" "-o"<br>
 // CHECK-EXCEP: "-fexceptions"<br>
<br>
+// CHECK-G0: xcc"<br>
+// CHECK-G0-NOT: "-g"<br>
+// CHECK-G0: xcc"<br>
+<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>