<div dir="ltr"><div><div>Hi Jiangning,<br><br></div>Sure.  Committed as r207642.  Thanks.<br><br>Sincerely,<br></div><div>Logan<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 30, 2014 at 4:47 PM, Jiangning Liu <span dir="ltr"><<a href="mailto:liujiangning1@gmail.com" target="_blank">liujiangning1@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Logan,<div><br></div><div>I noticed you only added test case for aarch64.</div><div><br></div><div>Actually we are merging aarch64 to arm64, so the current aarch64 port is going to be phased out and the name "arm64" will be changed to "aarch64" finally.</div>

<div><br></div><div>So could you please also add RUN for arm64 target as well?</div><div><br></div><div>Thanks,</div><div>-Jiangning<br><div class="gmail_extra"><br><br><div class="gmail_quote">2014-04-30 2:18 GMT+08:00 Logan Chien <span dir="ltr"><<a href="mailto:tzuhsiang.chien@gmail.com" target="_blank">tzuhsiang.chien@gmail.com</a>></span>:<div>
<div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: logan<br>
Date: Tue Apr 29 13:18:58 2014<br>
New Revision: 207567<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=207567&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=207567&view=rev</a><br>
Log:<br>
Android uses -fpic for aarch64.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Tools.cpp<br>
    cfe/trunk/test/Driver/pic.c<br>
<br>
Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207567&r1=207566&r2=207567&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207567&r1=207566&r2=207567&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Tools.cpp Tue Apr 29 13:18:58 2014<br>
@@ -2382,6 +2382,7 @@ void Clang::ConstructJob(Compilation &C,<br>
     case llvm::Triple::armeb:<br>
     case llvm::Triple::thumb:<br>
     case llvm::Triple::thumbeb:<br>
+    case llvm::Triple::aarch64:<br>
     case llvm::Triple::mips:<br>
     case llvm::Triple::mipsel:<br>
     case llvm::Triple::mips64:<br>
<br>
Modified: cfe/trunk/test/Driver/pic.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/pic.c?rev=207567&r1=207566&r2=207567&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/pic.c?rev=207567&r1=207566&r2=207567&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/test/Driver/pic.c (original)<br>
+++ cfe/trunk/test/Driver/pic.c Tue Apr 29 13:18:58 2014<br>
@@ -217,3 +217,5 @@<br>
 // RUN:   | FileCheck %s --check-prefix=CHECK-PIC1<br>
 // RUN: %clang -c %s -target mipsel-linux-android -### 2>&1 \<br>
 // RUN:   | FileCheck %s --check-prefix=CHECK-PIC1<br>
+// RUN: %clang -c %s -target aarch64-linux-android -### 2>&1 \<br>
+// RUN:   | FileCheck %s --check-prefix=CHECK-PIC1<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div><br></div></div></div>
</blockquote></div><br></div>