<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 23, 2014 at 10:16 PM, Nico Weber <span dir="ltr"><<a href="mailto:nicolasweber@gmx.de" target="_blank">nicolasweber@gmx.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":22p" class="a3s" style="overflow:hidden">+ if (DidSetDeprecatedMessage)<br>
+ clang_disposeString(*deprecated_message);<br>
*deprecated_message = cxstring::createDup(Deprecated->getMessage());<br>
+ DidSetDeprecatedMessage = true;</div></blockquote></div><br>Can we really not tell that the message doesn't hold a string to dispose of? Maybe even better, have clang_disposeString just no-op in that case (the way free, delete, etc do)?</div>
</div>