<div dir="ltr"><div>Floating point sounded like a pretty descriptive name when I chose it. I do see your point, a shorter warning name is usually preferred over a longer name.</div><div><br></div><div>Float:</div><div>-Wfloat-equal<br>
</div><div>-Wgnu-static-float-init</div><div>-Wstatic-float-init</div><div><br></div><div>Floating Point:<br><div>-Wimplicit-conversion-floating-point-to-bool<br></div></div><div><br></div><div>Existing warnings also show a preference for float. I will change this warning to float as well to be consistent.</div>
<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 22, 2014 at 1:19 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Name bikeshed: why -Wfloating-point-conversion and not -Wfloat-conversion? The other warnings are -Wbool-conversion and -Wint-conversion, not -Wboolean-conversion and -Winteger-conversion, and the latter covers other integer sizes as well. (Admittedly, though, you can say "unsigned short int" but not "double float".)<br>
<span class="HOEnZb"><font color="#888888"><br>
Jordan<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Apr 21, 2014, at 18:01 , Richard Trieu <<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>> wrote:<br>
<br>
> Author: rtrieu<br>
> Date: Mon Apr 21 20:01:05 2014<br>
> New Revision: 206832<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206832&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206832&view=rev</a><br>
> Log:<br>
> Move the warning of implicit cast of a floating point to an integer out of<br>
> -Wconversion and into it's own group, -Wfloating-point-conversion.<br>
><br>
> Added:<br>
> cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp<br>
> Modified:<br>
> cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
> cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=206832&r1=206831&r2=206832&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=206832&r1=206831&r2=206832&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Apr 21 20:01:05 2014<br>
> @@ -41,6 +41,7 @@ def PointerBoolConversion : DiagGroup<"p<br>
> def BoolConversion : DiagGroup<"bool-conversion", [ PointerBoolConversion ] >;<br>
> def IntConversion : DiagGroup<"int-conversion">;<br>
> def EnumConversion : DiagGroup<"enum-conversion">;<br>
> +def FloatingPointConversion : DiagGroup<"floating-point-conversion">;<br>
> def EnumTooLarge : DiagGroup<"enum-too-large">;<br>
> def NonLiteralNullConversion : DiagGroup<"non-literal-null-conversion">;<br>
> def NullConversion : DiagGroup<"null-conversion">;<br>
> @@ -476,6 +477,7 @@ def Conversion : DiagGroup<"conversion",<br>
> [BoolConversion,<br>
> ConstantConversion,<br>
> EnumConversion,<br>
> + FloatingPointConversion,<br>
> Shorten64To32,<br>
> IntConversion,<br>
> LiteralConversion,<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=206832&r1=206831&r2=206832&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=206832&r1=206831&r2=206832&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Mon Apr 21 20:01:05 2014<br>
> @@ -2319,7 +2319,7 @@ def warn_impcast_float_precision : Warni<br>
> InGroup<Conversion>, DefaultIgnore;<br>
> def warn_impcast_float_integer : Warning<<br>
> "implicit conversion turns floating-point number into integer: %0 to %1">,<br>
> - InGroup<Conversion>, DefaultIgnore;<br>
> + InGroup<FloatingPointConversion>, DefaultIgnore;<br>
> def warn_impcast_integer_sign : Warning<<br>
> "implicit conversion changes signedness: %0 to %1">,<br>
> InGroup<SignConversion>, DefaultIgnore;<br>
><br>
> Added: cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp?rev=206832&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp?rev=206832&view=auto</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp (added)<br>
> +++ cfe/trunk/test/SemaCXX/warn-floating-point-conversion.cpp Mon Apr 21 20:01:05 2014<br>
> @@ -0,0 +1,38 @@<br>
> +// RUN: %clang_cc1 -verify -fsyntax-only %s -Wfloating-point-conversion<br>
> +<br>
> +bool ReturnBool(float f) {<br>
> + return f; //expected-warning{{conversion}}<br>
> +}<br>
> +<br>
> +char ReturnChar(float f) {<br>
> + return f; //expected-warning{{conversion}}<br>
> +}<br>
> +<br>
> +int ReturnInt(float f) {<br>
> + return f; //expected-warning{{conversion}}<br>
> +}<br>
> +<br>
> +long ReturnLong(float f) {<br>
> + return f; //expected-warning{{conversion}}<br>
> +}<br>
> +<br>
> +void Convert(float f, double d, long double ld) {<br>
> + bool b;<br>
> + char c;<br>
> + int i;<br>
> + long l;<br>
> +<br>
> + b = f; //expected-warning{{conversion}}<br>
> + b = d; //expected-warning{{conversion}}<br>
> + b = ld; //expected-warning{{conversion}}<br>
> + c = f; //expected-warning{{conversion}}<br>
> + c = d; //expected-warning{{conversion}}<br>
> + c = ld; //expected-warning{{conversion}}<br>
> + i = f; //expected-warning{{conversion}}<br>
> + i = d; //expected-warning{{conversion}}<br>
> + i = ld; //expected-warning{{conversion}}<br>
> + l = f; //expected-warning{{conversion}}<br>
> + l = d; //expected-warning{{conversion}}<br>
> + l = ld; //expected-warning{{conversion}}<br>
> +}<br>
> +<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</div></div></blockquote></div><br></div>