<div dir="ltr">Thanks, I forgot the triple >_<.  <span style="color:rgb(0,0,0)">r206935</span></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 22, 2014 at 5:49 PM, Quentin Colombet <span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Reid,<br>
<br>
Looks like this broke some bots:<br>
<a href="http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16479" target="_blank">http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16479</a><br>
<br>
Could you take a look please?<br>
<br>
Thanks,<br>
-Quentin<br>
<div class="HOEnZb"><div class="h5">On Apr 22, 2014, at 5:15 PM, Reid Kleckner <<a href="mailto:reid@kleckner.net">reid@kleckner.net</a>> wrote:<br>
<br>
> Author: rnk<br>
> Date: Tue Apr 22 19:15:12 2014<br>
> New Revision: 206934<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206934&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206934&view=rev</a><br>
> Log:<br>
> Driver: Honor %INCLUDE% when built with MinGW<br>
><br>
> Users are expected to pass system includes through the INCLUDE<br>
> environment variable on Windows.  There's no reason to change behavior<br>
> based on the toolchain used to build Clang.<br>
><br>
> I didn't change the registry searching code because I'm not sure it<br>
> builds with mingw and I'm not set up to test it.<br>
><br>
> Added:<br>
>    cfe/trunk/test/Driver/windows-include-env.c<br>
> Modified:<br>
>    cfe/trunk/lib/Driver/WindowsToolChain.cpp<br>
><br>
> Modified: cfe/trunk/lib/Driver/WindowsToolChain.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/WindowsToolChain.cpp?rev=206934&r1=206933&r2=206934&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/WindowsToolChain.cpp?rev=206934&r1=206933&r2=206934&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/WindowsToolChain.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/WindowsToolChain.cpp Tue Apr 22 19:15:12 2014<br>
> @@ -293,7 +293,6 @@ void Windows::AddClangSystemIncludeArgs(<br>
>   if (DriverArgs.hasArg(options::OPT_nostdlibinc))<br>
>     return;<br>
><br>
> -#ifdef _MSC_VER<br>
>   // Honor %INCLUDE%. It should know essential search paths with vcvarsall.bat.<br>
>   if (const char *cl_include_dir = getenv("INCLUDE")) {<br>
>     SmallVector<StringRef, 8> Dirs;<br>
> @@ -305,6 +304,7 @@ void Windows::AddClangSystemIncludeArgs(<br>
>       return;<br>
>   }<br>
><br>
> +#ifdef _MSC_VER<br>
>   std::string VSDir;<br>
>   std::string WindowsSDKDir;<br>
><br>
><br>
> Added: cfe/trunk/test/Driver/windows-include-env.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/windows-include-env.c?rev=206934&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/windows-include-env.c?rev=206934&view=auto</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/Driver/windows-include-env.c (added)<br>
> +++ cfe/trunk/test/Driver/windows-include-env.c Tue Apr 22 19:15:12 2014<br>
> @@ -0,0 +1,4 @@<br>
> +// RUN: env INCLUDE=my_system_headers %clang -c %s -### 2>&1 | FileCheck %s<br>
> +// RUN: env INCLUDE=my_system_headers %clang_cl -c %s -### 2>&1 | FileCheck %s<br>
> +// CHECK: "-cc1"<br>
> +// CHECK: "-internal-isystem" "my_system_headers"<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>