<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 21, 2014 at 8:24 AM, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 21/04/2014 01:50, Richard Smith wrote:<div class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Sat, Apr 19, 2014 at 12:07 PM, Alp Toker <<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a> <mailto:<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>>> wrote:<br>
<br>
Author: alp<br>
Date: Sat Apr 19 14:07:24 2014<br>
New Revision: 206687<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206687&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=206687&view=rev</a><br>
Log:<br>
Move ObjC Cocoa.h header test to Headers<br>
<br>
This tests for broad compatibility with platform SDK headers using<br>
the clang<br>
driver and so belongs alongside the other header ingtegration tests.<br>
<br>
<br>
I agree that test/SemaObjC isn't the right place for this, but nor is test/Headers (which contains tests for the compiler-supplied headers in lib/Headers).<br>
</blockquote>
<br></div>
test/Headers contains tests against installed system headers as well as compiler-supplied headers right now (eg. cxx11.cpp, carbon.c) so it's not quite so clear cut.</blockquote><div><br></div><div>Yes, it's odd for carbon.c to be there. test/Headers/cxx11.cpp tests the lib/Headers headers (or at least intends to do so), so it's in the right place.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This seems like kind of a random and strange test to have at all, but if we really want this, test/Misc might be a better place.<br>
</blockquote>
<br></div>
I agree it'd be preferable to keep tests like this in their own place. That way they can be easily disabled when installed headers become incompatible as happened with PR18322 -- especially useful when bisecting historic builds on a more modern system.<br>
<br>
Not sure that test/Misc is the right place. How about introducing test/Integration for tests that cover integration with system headers?<br></blockquote><div><br></div><div>Yes, that sounds like a good place for carbon.c and cocoa.m (and probably eventually a test that includes windows.h, and so on).</div>
<div><br></div><div>warn-sysheader.cpp looks like it doesn't belong in test/Headers either; it should probably be in test/Misc with the other tests for the diagnostics infrastructure.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Alp.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<br>
Added:<br>
cfe/trunk/test/Headers/cocoa.m<br>
- copied, changed from r206686, cfe/trunk/test/SemaObjC/cocoa.<u></u>m<br>
Removed:<br>
cfe/trunk/test/SemaObjC/cocoa.<u></u>m<br>
<br>
Copied: cfe/trunk/test/Headers/cocoa.m (from r206686,<br>
cfe/trunk/test/SemaObjC/cocoa.<u></u>m)<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/cocoa.m?p2=cfe/trunk/test/Headers/cocoa.m&p1=cfe/trunk/test/SemaObjC/cocoa.m&r1=206686&r2=206687&rev=206687&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/test/<u></u>Headers/cocoa.m?p2=cfe/trunk/<u></u>test/Headers/cocoa.m&p1=cfe/<u></u>trunk/test/SemaObjC/cocoa.m&<u></u>r1=206686&r2=206687&rev=<u></u>206687&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/test/SemaObjC/cocoa.<u></u>m (original)<br>
+++ cfe/trunk/test/Headers/cocoa.m Sat Apr 19 14:07:24 2014<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats<br>
+// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats<br>
#ifdef __APPLE__<br>
#include <Cocoa/Cocoa.h><br>
#endif<br>
<br>
Removed: cfe/trunk/test/SemaObjC/cocoa.<u></u>m<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/cocoa.m?rev=206686&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/cfe/trunk/test/<u></u>SemaObjC/cocoa.m?rev=206686&<u></u>view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- cfe/trunk/test/SemaObjC/cocoa.<u></u>m (original)<br>
+++ cfe/trunk/test/SemaObjC/cocoa.<u></u>m (removed)<br>
@@ -1,5 +0,0 @@<br>
-// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats<br>
-#ifdef __APPLE__<br>
-#include <Cocoa/Cocoa.h><br>
-#endif<br>
-<br>
<br>
<br>
______________________________<u></u>_________________<br>
cfe-commits mailing list<br></div></div>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/cfe-commits</a><br>
<br>
<br><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
<a href="http://www.nuanti.com" target="_blank">http://www.nuanti.com</a><br>
the browser experts<br>
<br>
</font></span></blockquote></div><br></div></div>