<div dir="ltr">LGTM please commit.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 16 April 2014 15:07, Jon Roelofs <span dir="ltr"><<a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Removed the arm bits for now.<br>
<br>
Hi nlewycky,<br>
<br>
<a href="http://reviews.llvm.org/D3385" target="_blank">http://reviews.llvm.org/D3385</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://reviews.llvm.org/D3385?vs=8539&id=8587#toc" target="_blank">http://reviews.llvm.org/D3385?vs=8539&id=8587#toc</a><br>
<br>
Files:<br>
  src/Unwind/Registers.hpp<br>
<br>
Index: src/Unwind/Registers.hpp<br>
===================================================================<br>
--- src/Unwind/Registers.hpp<br>
+++ src/Unwind/Registers.hpp<br>
@@ -15,6 +15,7 @@<br>
<br>
 #include <stdint.h><br>
 #include <strings.h><br>
+#include <string.h><br>
<br>
 #include "libunwind.h"<br>
 #include "config.h"<br>
@@ -91,7 +92,7 @@<br>
 }<br>
<br>
 inline Registers_x86::Registers_x86() {<br>
-  bzero(&_registers, sizeof(_registers));<br>
+  memset(&_registers, 0, sizeof(_registers));<br>
 }<br>
<br>
 inline bool Registers_x86::validRegister(int regNum) const {<br>
@@ -282,7 +283,7 @@<br>
 }<br>
<br>
 inline Registers_x86_64::Registers_x86_64() {<br>
-  bzero(&_registers, sizeof(_registers));<br>
+  memset(&_registers, 0, sizeof(_registers));<br>
 }<br>
<br>
 inline bool Registers_x86_64::validRegister(int regNum) const {<br>
@@ -548,9 +549,9 @@<br>
 }<br>
<br>
 inline Registers_ppc::Registers_ppc() {<br>
-  bzero(&_registers, sizeof(_registers));<br>
-  bzero(&_floatRegisters, sizeof(_floatRegisters));<br>
-  bzero(&_vectorRegisters, sizeof(_vectorRegisters));<br>
+  memset(&_registers, 0, sizeof(_registers));<br>
+  memset(&_floatRegisters, 0, sizeof(_floatRegisters));<br>
+  memset(&_vectorRegisters, 0, sizeof(_vectorRegisters));<br>
 }<br>
<br>
 inline bool Registers_ppc::validRegister(int regNum) const {<br>
@@ -1065,8 +1066,8 @@<br>
 }<br>
<br>
 inline Registers_arm64::Registers_arm64() {<br>
-  bzero(&_registers, sizeof(_registers));<br>
-  bzero(&_vectorHalfRegisters, sizeof(_vectorHalfRegisters));<br>
+  memset(&_registers, 0, sizeof(_registers));<br>
+  memset(&_vectorHalfRegisters, 0, sizeof(_vectorHalfRegisters));<br>
 }<br>
<br>
 inline bool Registers_arm64::validRegister(int regNum) const {<br>
@@ -1329,7 +1330,7 @@<br>
 }<br>
<br>
 inline Registers_arm::Registers_arm() {<br>
-  bzero(&_registers, sizeof(_registers));<br>
+  memset(&_registers, 0, sizeof(_registers));<br>
 }<br>
<br>
 inline bool Registers_arm::validRegister(int regNum) const {<br>
</blockquote></div><br></div>