<div dir="ltr">Should tools/clang/lib/Headers/module.map be renamed to the new name?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 20, 2014 at 7:47 AM, Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Thanks for letting me know. Looks like Aaron Ballman already fixed this in r204345.<div>
<br></div><div>Be</div><div><div class="h5"><div><br><div><div>On Mar 20, 2014, at 6:11 AM, Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2014-03-20 0:23 GMT+04:00 Ben Langmuir <span dir="ltr"><<a href="mailto:blangmuir@apple.com" target="_blank">blangmuir@apple.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden"> bool <span>HeaderSearch</span>::loadModuleMapFile(const FileEntry *File, bool IsSystem) {<br>
+ switch (loadModuleMapFileImpl(File, IsSystem)) {<br>
+ case LMM_AlreadyLoaded:<br>
+ case LMM_NewlyLoaded:<br>
+ return false;<br>
+ case LMM_NoDirectory:<br>
+ case LMM_InvalidModuleMap:<br>
+ return true;<br>
+ }<br>
+}</div></blockquote></div><div class="gmail_extra"><br></div>FYI</div><div class="gmail_extra">gcc-4.8.2 doesn't like it:<br><div class="gmail_extra">../tools/clang/lib/Lex/HeaderSearch.cpp: In member function ‘bool clang::HeaderSearch::loadModuleMapFile(const clang::FileEntry*, bool)’:</div>
<div class="gmail_extra">../tools/clang/lib/Lex/HeaderSearch.cpp:1159:1: warning: control reaches end of non-void function [-Wreturn-type]</div><div class="gmail_extra"> }</div><div class="gmail_extra"> ^</div></div></div>
</blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>