<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Apr 4, 2014 at 3:47 AM, Lubos Lunak <span dir="ltr"><<a href="mailto:l.lunak@centrum.cz" target="_blank">l.lunak@centrum.cz</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
This is a re-send of<br>
<a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131125/094231.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131125/094231.html</a><br>
which went without any answer.<br>
<br>
See PR15614 for a testcase.</blockquote><div><br></div><div>The combination of -Wunused-macro and -frewrite-includes still doesn't really work with this patch applied: if the only use of a macro is within a preprocessor directive that -frewrite-includes expands, we'll still warn about it. Unfortunately I don't have any great ideas as to how to solve this; the least bad idea I have is to add a '#pragma clang macro_used BLAH', and emit that for each macro that's used in the -frewrite-includes run.</div>
</div></div></div>