<div dir="ltr">Hi!<div><br></div><div>I'm afraid this patch is incorrect; it even does the wrong thing in your test case. Skipping the setInstantiatedFromMemberTemplate call causes us to mix up the template parameter list numbering -- we substitute the argument given for T as the value U, and we don't substitute anything for T. For instance, in the definition of f instantiated for the f(3.0) call, we should have T=double, U=int, but we actually have T=<no value>, U=double, as can be seen in the AST dump.</div>
<div><br></div><div>This also does the wrong thing if C is instantiated twice -- such a case should be an error, because f would have multiple definitions.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Mar 24, 2014 at 5:29 AM, suyog sarda <span dir="ltr"><<a href="mailto:sardask01@gmail.com" target="_blank">sardask01@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Gentle Ping!!</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 20, 2014 at 9:46 AM, suyog sarda <span dir="ltr"><<a href="mailto:sardask01@gmail.com" target="_blank">sardask01@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Gentle Ping!!<br></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Mar 14, 2014 at 10:29 PM, suyog sarda <span dir="ltr"><<a href="mailto:sardask01@gmail.com" target="_blank">sardask01@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi,<br><br></div>Attaching patch for bug 19095. Please help in reviewing the same.<br><br>
</div>Also, I haven't attached a test case yet in the patch as i am not sure how it should be and in which file it should be. <br>
<br></div>In my opinion, the test case would go into <i>tools/clang/test/SemaCXX/friend.cpp </i>would be something like below (similar to that mentioned in the bug)<br><span><span><i><br>
template <class T><br>void f(T);<br><br>template <class U><br>class C<br>{<br> template <class T><br> friend void f(T)<br> {<br> C<U> c;<br> c.i = 3;<br> }<br><br> public :<br><br> void g()<br>
{<br> f(3.0); // OK<br> }<br> int i;<br>};<br><br>void h ()<br>{<br> f(7); // OK<br> C<double> c;<br> c.g();<br>}</i><br clear="all"></span></span><div><div><div><div><br></div><div><br></div><div>
Please help in reviewing the patch as well as the test case.<span><font color="#888888"><br></font></span></div><span><font color="#888888"><div>-- <br>With regards,<br>Suyog Sarda<br>
</div></font></span></div></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>With regards,<br>Suyog Sarda<br>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>With regards,<br>Suyog Sarda<br>
</div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>