<div dir="ltr">Made it a namespace in r205935 with inline.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Apr 9, 2014 at 2:47 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Apr 9, 2014 at 5:33 PM, Justin Bogner <<a href="mailto:mail@justinbogner.com">mail@justinbogner.com</a>> wrote:<br>

> Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> writes:<br>
>> Thread Safety Analysis: some minor cleanups to the latest thread<br>
>> safety changes. No functional changes intended.<br>
>><br>
>> * Adds an iterator_range interface to CallExpr to get the arguments<br>
>> * Modifies SExpr such that it must be allocated in the Arena, and<br>
>> cannot be deleted<br>
>> * Minor const-correctness and nullptr updates<br>
>> * Adds some operator!= implementations to complement operator==<br>
>> * Removes unused functionality<br>
>><br>
>> Modified:<br>
>>     cfe/trunk/include/clang/AST/Expr.h<br>
>>     cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyCommon.h<br>
>>     cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h<br>
>>     cfe/trunk/lib/Analysis/ThreadSafetyCommon.cpp<br>
>  ...<br>
>> Modified: cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h<br>
>> URL:<br>
>>     <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h?rev=205915&r1=205914&r2=205915&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h?rev=205915&r1=205914&r2=205915&view=diff</a><br>

>> ==============================================================================<br>
>> --- cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h (original)<br>
>> +++ cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h Wed Apr  9 12:45:44 2014<br>
>  ...<br>
>>  // Contains various helper functions for SExprs.<br>
>> -class ThreadSafetyTIL {<br>
>> -public:<br>
>> -  static const int MaxOpcode = COP_MAX;<br>
>> -<br>
>> -  static inline bool isTrivial(SExpr *E) {<br>
>> -    unsigned Op = E->opcode();<br>
>> -    return Op == COP_Variable || Op == COP_Literal || Op == COP_LiteralPtr;<br>
>> -  }<br>
>> -<br>
>> -  static inline bool isLargeValue(SExpr *E) {<br>
>> -    unsigned Op = E->opcode();<br>
>> -    return (Op >= COP_Function && Op <= COP_Code);<br>
>> -  }<br>
>> -};<br>
>> -<br>
>> +namespace ThreadSafetyTIL {<br>
>> +static bool isTrivial(SExpr *E) {<br>
>> +  unsigned Op = E->opcode();<br>
>> +  return Op == COP_Variable || Op == COP_Literal || Op == COP_LiteralPtr;<br>
>> +}<br>
>> +}<br>
><br>
> I don't think isTrivial should be static. I'm getting a warning about<br>
> this being an unused function during the compile of ThreadSafety.cpp<br>
> after this change.<br>
<br>
</div></div>I agree -- I guess MSVC doesn't warn about this. I've switched back to<br>
a class-scope static in r205931 -- thank you for the heads up!<br>
<span class="HOEnZb"><font color="#888888"><br>
~Aaron<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>