<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 7, 2014 at 4:22 PM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank" class="cremed">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""><p dir="ltr">On Apr 7, 2014 6:43 PM, "Samuel Benzaquen" <<a href="mailto:sbenza@google.com" target="_blank" class="cremed">sbenza@google.com</a>> wrote:<br>
><br>
> On Mon, Apr 7, 2014 at 1:14 PM, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank" class="cremed">klimek@google.com</a>> wrote:<br>
>><br>
>> On Mon, Apr 7, 2014 at 6:29 PM, Samuel Benzaquen <<a href="mailto:sbenza@google.com" target="_blank" class="cremed">sbenza@google.com</a>> wrote:<br>
>>><br>
>>> Fixed the typo on shared_ptr and added a shared_ptr to the test.<br>
>>><br>
>>> Fixed the -fix.cpp test to actually check the output.<br>
>>> FileCheck can match the CHECK: lines with themselves if you don't remove them from the input.<br>
>><br>
>><br>
>> Any reason not to use the same pattern in all tests (they get cargo culted a lot).<br>
><br>
><br>
> I am figuring out how FileCheck works as I go.<br>
> I have been also wondering why we don't have all these as scripts. imo, the test should have a single line at the top:<br>
> // RUN: check_clang_tidy_fix.sh <check-name> %s %t %T<br>
> or something like that. Instead of copying the same N lines everywhere (and changing them slightly).</p>
</div><p dir="ltr">I think that's a great idea... Go ahead :-)</p></blockquote><div>Done.</div><div>Added one script for the command line output and one for the in-file fix.</div></div></div></div>